Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Less permissive bwrap options #999

Merged
merged 1 commit into from Feb 16, 2022
Merged

Conversation

Shrews
Copy link
Contributor

@Shrews Shrews commented Feb 16, 2022

No description provided.

@Shrews Shrews requested a review from a team as a code owner February 16, 2022 16:14
@Shrews Shrews changed the title [DNM] Better bwrap [DNM] Less permissive bwrap options Feb 16, 2022
@Shrews Shrews force-pushed the bwrap-fix branch 3 times, most recently from 090ee31 to 9b8ad01 Compare February 16, 2022 16:51
@Shrews Shrews changed the title [DNM] Less permissive bwrap options Less permissive bwrap options Feb 16, 2022
@Shrews Shrews added the gate label Feb 16, 2022
@Shrews Shrews added the gate label Feb 16, 2022
@ansible-zuul ansible-zuul bot merged commit 3ab4473 into ansible:devel Feb 16, 2022
Shrews added a commit to Shrews/ansible-runner that referenced this pull request Feb 17, 2022
Less permissive bwrap options

Reviewed-by: Shane McDonald <me@shanemcd.com>
(cherry picked from commit 3ab4473)
Shrews added a commit to Shrews/ansible-runner that referenced this pull request Feb 17, 2022
Less permissive bwrap options

Reviewed-by: Shane McDonald <me@shanemcd.com>
(cherry picked from commit 3ab4473)
Shrews added a commit to Shrews/ansible-runner that referenced this pull request Feb 17, 2022
ansible-zuul bot pushed a commit that referenced this pull request Feb 17, 2022
[backport][release_2.1] Less permissive bwrap options (#999)

Backport of PR #999
(cherry picked from commit 3ab4473)

Reviewed-by: Shane McDonald <me@shanemcd.com>
ansible-zuul bot pushed a commit that referenced this pull request Feb 17, 2022
[backport][release_2.0] Less permissive bwrap options (#999)

Backport of PR #999
(cherry picked from commit 3ab4473)

Reviewed-by: Shane McDonald <me@shanemcd.com>
shanemcd added a commit that referenced this pull request Feb 17, 2022
[backport][stable/1.4.x] Less permissive bwrap options (#999)
@Shrews Shrews deleted the bwrap-fix branch February 17, 2022 16:26
ansible-zuul bot pushed a commit that referenced this pull request Mar 8, 2022
Fix broken password-based SSH

Fallout from the recent changes in #999.
I came up with the solution here after piecing together info in comments from @sivel and @jborean93. (thanks!)
Users who tried to use SSH w/ a login password were seeing:
<ec2-44-203-148-21.compute-1.amazonaws.com> SSH: EXEC sshpass -d8 ssh -C -o ControlMaster=auto -o ControlPersist=60s -o 'User="testuser"' -o ConnectTimeout=10 -o ControlPath=/var/lib/awx/.ansible/cp/6abb5dc2c2 ec2-44-203-148-21.compute-1.amazonaws.com '/bin/sh -c '"'"'( umask 77 && mkdir -p "` echo ~/.ansible/tmp `"&& mkdir "` echo ~/.ansible/tmp/ansible-tmp-1646413970.94-16-215594703579950 `" && echo ansible-tmp-1646413970.94-16-215594703579950="` echo ~/.ansible/tmp/ansible-tmp-1646413970.94-16-215594703579950 `" ) && sleep 0'"'"''
<ec2-44-203-148-21.compute-1.amazonaws.com> (3, '', "Failed to change pseudo terminal's permission: Operation not permitted\n")
<ec2-44-203-148-21.compute-1.amazonaws.com> Failed to connect to the host via ssh: Failed to change pseudo terminal's permission: Operation not permitted
ec2-44-203-148-21.compute-1.amazonaws.com | UNREACHABLE! => {
    "changed": false,
    "msg": "Failed to create temporary directory.In some cases, you may have been able to authenticate and did not have permissions on the target directory. Consider changing the remote tmp path in ansible.cfg to a path rooted in \"/tmp\", for more error information use -vvv. Failed command was: ( umask 77 && mkdir -p \"` echo ~/.ansible/tmp `\"&& mkdir \"` echo ~/.ansible/tmp/ansible-tmp-1646413970.94-16-215594703579950 `\" && echo ansible-tmp-1646413970.94-16-215594703579950=\"` echo ~/.ansible/tmp/ansible-tmp-1646413970.94-16-215594703579950 `\" ), exited with result 3",
    "unreachable": true
}

Critical part being Failed to change pseudo terminal's permission: Operation not permitted.

Reviewed-by: David Shrewsbury <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants