Implement ansible's resolved action

[matburt]

This supercedes #816

This also includes some black formatting changes.

[matburt]

47ee0e5 keeps us from resurfacing #969

[cidrblock]

+1, not because I completely grok it all but because it doesn't use distulils :)

[matburt]

I'm not crazy about what the is_pre_ansible211 test does. It doesn't seem like it'll work in the general case.

[matburt]

I'm also not sure how I feel about this implementation generally but it gets us there quick with whatever variant of Ansible is installed in the environment.

[Shrews]

The is_pre_ansible211 fixture should work in the general case. The ansible package used in our tests will be ansible-core for 2.11 or higher. 2.10 is ansible-base, and 2.9 and earlier is ansible.

[shanemcd]

@simaishi Can you check and see if this is available as an RPM from the standard repos?

[matburt]

🤞🏻 it's also used by ansible-core so my working assumption was that we had solved it for the necessary dependencies.

[simaishi]

ansible-core has it bundled, but we do have an access to the standalone rpm as well.

[AlanCoding]

This looks most similar to the task_action key... makes sense, right? Before, we had task_action, now we have resolved_action in addition to that. But those are handled in separate parts of the code, and I haven't understood why. We seem to get both of them from the same task object... so why would they be in different places?

[AlanCoding]

To give my comment greater specificity,

diff --git a/ansible_runner/display_callback/callback/awx_display.py b/ansible_runner/display_callback/callback/awx_display.py
index aa29f39..0aee596 100644
--- a/ansible_runner/display_callback/callback/awx_display.py
+++ b/ansible_runner/display_callback/callback/awx_display.py
@@ -409,6 +409,7 @@ class CallbackModule(DefaultCallbackModule):
             task=(task.name or task.action),
             task_uuid=str(task._uuid),
             task_action=task.action,
+            resolved_action=getattr(task, 'resolved_action', ''),
             task_args='',
         )
         try:
@@ -554,7 +555,6 @@ class CallbackModule(DefaultCallbackModule):
             name=task.get_name(),
             is_conditional=is_conditional,
             uuid=task_uuid,
-            resolved_action=getattr(task, 'resolved_action', '')
         )
         with self.capture_event_data('playbook_on_task_start', **event_data):
             super(CallbackModule, self).v2_playbook_on_task_start(task, is_conditional)

this would seem more clear and still passes the test

[shanemcd]

recheck

[softwarefactory-project-zuul]

Build succeeded.

• ansible-build-python-tarball : SUCCESS in 4m 48s

[AlanCoding]

@Shrews in the future, I want to make sure that we do integration testing with AWX before merging any change intended to be consumed by AWX. In this case, I did, and those were passing.

[Shrews]

@AlanCoding Ok. @shanemcd had asked me about merging this today, so I assumed that was already done.