Fix bug with sandboxing with values from env/settings #978
+60
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
needs_triage
eqrx
approved these changes
Jan 27, 2022
![ansible-zuul[bot]](https://avatars.githubusercontent.com/in/27800?s=60&v=4){kind=small}
Shrews
added a commit
to Shrews/ansible-runner
that referenced
this pull request
Jan 31, 2022
Fix bug with sandboxing with values from env/settings Fixes ansible#977 Sandboxing with directory isolation did not work when values were defined via env/settings. Unit test for this required moving the project_fixtures pytest fixture from the integration directory to the top-level test directory where it could be used by unit tests, as well. Reviewed-by: Alexander Sowitzki <dev@eqrx.net> Reviewed-by: None <None> (cherry picked from commit 996a00d)
Shrews
added a commit
to Shrews/ansible-runner
that referenced
this pull request
Jan 31, 2022
Fix bug with sandboxing with values from env/settings Fixes ansible#977 Sandboxing with directory isolation did not work when values were defined via env/settings. Unit test for this required moving the project_fixtures pytest fixture from the integration directory to the top-level test directory where it could be used by unit tests, as well. Reviewed-by: Alexander Sowitzki <dev@eqrx.net> Reviewed-by: None <None> (cherry picked from commit 996a00d)
ansible-zuul bot
pushed a commit
that referenced
this pull request
Jan 31, 2022
[backport][release_2.1] Fix bug with sandboxing with values from env/settings (#978) Backport of PR #978 This also standardizes .gitignore from a change that was not backported to this branch. (cherry picked from commit 996a00d) Reviewed-by: Alexander Sowitzki <dev@eqrx.net> Reviewed-by: None <None>
ansible-zuul bot
pushed a commit
that referenced
this pull request
Jan 31, 2022
[backport][release_2.0] Fix bug with sandboxing with values from env/settings (#978) Backport of PR #978 This also standardizes .gitignore from a change that was not backported to this branch. (cherry picked from commit 996a00d) Reviewed-by: Alexander Sowitzki <dev@eqrx.net> Reviewed-by: None <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #977
Sandboxing with directory isolation did not work when values were defined via
env/settings.Unit test for this required moving the
project_fixturespytest fixture from theintegrationdirectory to the top-level test directory where it could be used by unit tests, as well.