Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove use of distutils #976

Merged
merged 1 commit into from Jan 31, 2022
Merged

Remove use of distutils #976

merged 1 commit into from Jan 31, 2022

Conversation

Shrews
Copy link
Contributor

@Shrews Shrews commented Jan 24, 2022 •
edited

Fixes #969

@github-actions github-actions bot added needs_triage New item that needs to be triaged test Changes to test files labels Jan 24, 2022
@Shrews Shrews removed the needs_triage New item that needs to be triaged label Jan 25, 2022
@Shrews
Copy link
Contributor Author

Shrews commented Jan 26, 2022

The copytree() portion of code used for directory isolation does not seem to be covered by any tests. I'd like to add a test for that before merging this change. However, I discovered a bug in that bit of code that needs fixed before we can merge this (see issue #977).

@Shrews Shrews force-pushed the replace_distutils branch 3 times, most recently from 8040e41 to 1afdc73 Compare January 27, 2022 19:06
@Shrews Shrews marked this pull request as ready for review January 27, 2022 19:47
@Shrews Shrews requested a review from a team as a code owner January 27, 2022 19:47
@Shrews Shrews added the needs_triage New item that needs to be triaged label Jan 27, 2022
@eqrx eqrx added the gate label Jan 28, 2022
ansible-zuul[bot]
ansible-zuul bot approved these changes Jan 28, 2022
View reviewed changes
Copy link
Contributor

@ansible-zuul ansible-zuul bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Shrews Shrews added gate and removed gate needs_triage New item that needs to be triaged labels Jan 31, 2022
@ansible-zuul ansible-zuul bot merged commit f1b6c3a into ansible:devel Jan 31, 2022
@Shrews Shrews deleted the replace_distutils branch January 31, 2022 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ansible-zuul ansible-zuul[bot] ansible-zuul approved these changes

@eqrx eqrx eqrx approved these changes

Assignees
No one assigned
Labels
test Changes to test files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stop using distutils
2 participants
@Shrews @eqrx