Do some test cleanup #952
Merged
Do some test cleanup #952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
recheck |
AlanCoding
approved these changes
Jan 7, 2022
eqrx
approved these changes
Jan 10, 2022
![ansible-zuul[bot]](https://avatars.githubusercontent.com/in/27800?s=60&v=4){kind=small}
Shrews
added a commit
to Shrews/ansible-runner
that referenced
this pull request
Jan 27, 2022
Do some test cleanup We have been seeing some random test failures due to No space left on device errors. Not entirely sure what is causing that, but this is at least a start. This will remove the copy of the test project tree that is made for every test that uses the project_fixtures fixture. Also, remove a now unused pytest fixture (clear_integration_artifacts). Also fix a flaky test (test_stdout_file_no_write) that fails randomly under pexpect preventing this from merging. The assert's being removed are not actually testing the feature. Reviewed-by: Alan Rominger <arominge@redhat.com> Reviewed-by: Alexander Sowitzki <dev@eqrx.net> Reviewed-by: None <None> (cherry picked from commit 0e451fc)
Shrews
added a commit
to Shrews/ansible-runner
that referenced
this pull request
Jan 27, 2022
Do some test cleanup We have been seeing some random test failures due to No space left on device errors. Not entirely sure what is causing that, but this is at least a start. This will remove the copy of the test project tree that is made for every test that uses the project_fixtures fixture. Also, remove a now unused pytest fixture (clear_integration_artifacts). Also fix a flaky test (test_stdout_file_no_write) that fails randomly under pexpect preventing this from merging. The assert's being removed are not actually testing the feature. Reviewed-by: Alan Rominger <arominge@redhat.com> Reviewed-by: Alexander Sowitzki <dev@eqrx.net> Reviewed-by: None <None> (cherry picked from commit 0e451fc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have been seeing some random test failures due to
No space left on deviceerrors. Not entirely sure what is causing that, but this is at least a start. This will remove the copy of the test project tree that is made for every test that uses theproject_fixturesfixture.Also, remove a now unused pytest fixture (
clear_integration_artifacts).Also fix a flaky test (
test_stdout_file_no_write) that fails randomly underpexpectpreventing this from merging. Theassert's being removed are not actually testing the feature.