Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New interface methods for role list and role argspec #920

Merged
merged 7 commits into from Nov 30, 2021
Merged

New interface methods for role list and role argspec #920

merged 7 commits into from Nov 30, 2021

Conversation

Shrews
Copy link
Contributor

@Shrews Shrews commented Nov 10, 2021 •
edited

This adds two new API methods to the runner interface:

  • get_role_list() - Get a list of roles that have defined an argument specification.
  • get_role_argspec() - Get the argument specification for a given role.

@samdoran samdoran added the needs_triage New item that needs to be triaged label Nov 18, 2021
@Shrews Shrews marked this pull request as ready for review November 19, 2021 17:59
@Shrews Shrews requested a review from a team as a code owner November 19, 2021 17:59
@Shrews Shrews requested a review from shanemcd November 19, 2021 18:00
samdoran
samdoran approved these changes Nov 29, 2021
View reviewed changes
Copy link
Contributor

@samdoran samdoran left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a bunch of minor things, no blockers.

I verified the tests add 100% coverage to net new code and performed a functional test of the new API endpoints. They work as advertised.

docs/python_interface.rst Show resolved Hide resolved
test/integration/test_interface.py Outdated Show resolved Hide resolved
ansible_runner/interface.py Outdated Show resolved Hide resolved
ansible_runner/interface.py Outdated Show resolved Hide resolved
ansible_runner/interface.py Outdated Show resolved Hide resolved
ansible_runner/interface.py Outdated Show resolved Hide resolved
ansible_runner/interface.py Outdated Show resolved Hide resolved
ansible_runner/interface.py Outdated Show resolved Hide resolved
ansible_runner/interface.py Outdated Show resolved Hide resolved
ansible_runner/interface.py Outdated Show resolved Hide resolved
@samdoran samdoran removed the needs_triage New item that needs to be triaged label Nov 30, 2021
@samdoran samdoran added the gate label Nov 30, 2021
ansible-zuul[bot]
ansible-zuul bot approved these changes Nov 30, 2021
View reviewed changes
Copy link
Contributor

@ansible-zuul ansible-zuul bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ansible-zuul ansible-zuul bot merged commit 8695730 into ansible:devel Nov 30, 2021
samdoran pushed a commit to samdoran/ansible-runner that referenced this pull request Dec 2, 2021
@Shrews @samdoran
New interface methods for role list and role argspec (ansible#920)
43a1495 
New interface methods for role list and role argspec

This adds two new API methods to the runner interface:

get_role_list() - Get a list of roles that have defined an argument specification.
get_role_argspec() - Get the argument specification for a given role.

Reviewed-by: Sam Doran <sdoran@redhat.com>
Reviewed-by: David Shrewsbury <None>
Reviewed-by: None <None>
@Shrews Shrews deleted the roleargspec2 branch December 6, 2021 14:53
@MLNW
Copy link

MLNW commented Jan 15, 2022

I'm interested in this functionality since it is advertised in the documentation but I take it that it has not been released yet.

Is there an ETA for that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samdoran samdoran samdoran approved these changes

@ansible-zuul ansible-zuul[bot] ansible-zuul approved these changes

@shanemcd shanemcd Awaiting requested review from shanemcd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Shrews @MLNW @samdoran