Write auto-created private data dirs to pytest dir instead of /tmp #916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samdoran
added
needs_triage
samdoran
reviewed
Dec 7, 2021
samdoran
reviewed
Dec 7, 2021
samdoran
reviewed
Dec 7, 2021
Co-authored-by: Sam Doran <sdoran@redhat.com>
samdoran
approved these changes
Dec 14, 2021
![ansible-zuul[bot]](https://avatars.githubusercontent.com/in/27800?s=60&v=4){kind=small}
|
recheck |
samdoran
pushed a commit
to samdoran/ansible-runner
that referenced
this pull request
Dec 14, 2021
…ead of /tmp (ansible#916) Write auto-created private data dirs to pytest dir instead of /tmp I briefly discussed this option with @samdoran in ansible#901 After this patch, we create directories that look like: /tmp/pytest-of-alancoding/pytest-0/popen-gw2/test_no_dst_all_dirs_src__dir_0/.ansible-runner-2fpvb4uo This is as opposed to leaving around directories like /tmp/.ansible-runner-2fpvb4uo. There are a lot of these, like ~1,700 created with a single test run excluding the integration tests. There are still a few directories created in /tmp after this, but it's a handful, not a flood. Reviewed-by: Sam Doran <github@samdoran.com> Reviewed-by: None <None> (cherry picked from commit 7f9de03) Co-authored-by: Alan Rominger <arominge@redhat.com>
samdoran
pushed a commit
to samdoran/ansible-runner
that referenced
this pull request
Dec 14, 2021
…ead of /tmp (ansible#916) Write auto-created private data dirs to pytest dir instead of /tmp I briefly discussed this option with @samdoran in ansible#901 After this patch, we create directories that look like: /tmp/pytest-of-alancoding/pytest-0/popen-gw2/test_no_dst_all_dirs_src__dir_0/.ansible-runner-2fpvb4uo This is as opposed to leaving around directories like /tmp/.ansible-runner-2fpvb4uo. There are a lot of these, like ~1,700 created with a single test run excluding the integration tests. There are still a few directories created in /tmp after this, but it's a handful, not a flood. Reviewed-by: Sam Doran <github@samdoran.com> Reviewed-by: None <None>. (cherry picked from commit 7f9de03) Co-authored-by: Alan Rominger <arominge@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I briefly discussed this option with @samdoran in #901
After this patch, we create directories that look like:
This is as opposed to leaving around directories like
/tmp/.ansible-runner-2fpvb4uo. There are a lot of these, like ~1,700 created with a single test run excluding the integration tests.There are still a few directories created in
/tmpafter this, but it's a handful, not a flood.