Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.2 backport] remove any pipe files before zip/unzipping (#1133) #1150

Merged
merged 1 commit into from Nov 1, 2022

Conversation

nitzmahone
Copy link
Member

  • Write test to demonstrate job hang on pipes

  • Remove any pipe files before zip/unzipping

  • Prevents hangs when zipping, unzipping artifacts dir. If python attempts to open a fifo pipe, it will block indefinitely until it can read data from the pipe.
  • move fifo check below symlink

Co-authored-by: Alan Rominger arominge@redhat.com
(cherry picked from commit 8f39752)

* Write test to demonstrate job hang on pipes

* Remove any pipe files before zip/unzipping

- Prevents hangs when zipping, unzipping artifacts dir. If python
attempts to open a fifo pipe, it will block indefinitely until it can
read data from the pipe.

* move fifo check below symlink

Co-authored-by: Alan Rominger <arominge@redhat.com>
(cherry picked from commit 8f39752)
@nitzmahone nitzmahone requested a review from a team as a code owner October 28, 2022 23:11
@Shrews Shrews merged commit 8d49775 into ansible:release_2.2 Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants