Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bp/2.2] Make sure we close stdout/stderr in Runner.run() #1125

Merged
merged 1 commit into from Sep 8, 2022
Merged

[bp/2.2] Make sure we close stdout/stderr in Runner.run() #1125

merged 1 commit into from Sep 8, 2022

Conversation

Shrews
Copy link
Contributor

@Shrews Shrews commented Sep 7, 2022

  • Make sure we close stdout/stderr
  • Remove unnecessary flush() calls

(cherry picked from commit 2eab201)

@Shrews
Make sure we close stdout/stderr in Runner.run() (ansible#1123)
0429c20 
* Make sure we close stdout/stderr
* Remove unnecessary flush() calls

(cherry picked from commit 2eab201)
@Shrews Shrews requested a review from a team as a code owner September 7, 2022 13:49
@github-actions github-actions bot added the needs_triage New item that needs to be triaged label Sep 7, 2022
@Akasurde Akasurde added gate and removed needs_triage New item that needs to be triaged labels Sep 8, 2022
@Akasurde Akasurde changed the title [backport][release_2.2] Make sure we close stdout/stderr in Runner.run() (#1123) [bp/2.2] Make sure we close stdout/stderr in Runner.run() Sep 8, 2022
@Akasurde Akasurde merged commit a12121b into ansible:release_2.2 Sep 8, 2022
@Shrews Shrews deleted the backport/release_2.2/pr1123 branch September 8, 2022 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Akasurde Akasurde Akasurde approved these changes

@eqrx eqrx eqrx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Shrews @Akasurde @eqrx