New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linting fixes #1112
Linting fixes #1112
Conversation
Remove the I'll work on removing other unneeded entries in that and other requirements files for us in a separate PR, if any. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will probably require a backport. Not sure if that will cause issues.
This is likely to cause problems with images depending on the removed libs.
Have you identified what changed (flake8 update maybe?) to cause these linting issues to appear? It might be worth considering pinning the linting tools to a specific version to prevent this from happening (and then update the version on major releases). |
* Added whitespace after keyword * Pinned flake8 version to 4.0.1 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Probably needs backported.
SUMMARY
flake8
to 4.0.1 for nowENV PIP_OPTS=--no-build-isolation
Signed-off-by: Abhijeet Kasurde akasurde@redhat.com
ISSUE TYPE
COMPONENT NAME
ansible_runner/main.py
ansible_runner/cleanup.py