New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make yamllint rule compatible with prettier #1104

Merged

Akasurde merged 1 commit into ansible:devel from ssbarnea:chore/style

Jul 19, 2022

Member

ssbarnea commented Jul 19, 2022 •

edited

Adapts yamllint config to not require two char indentation for inline comments as that is in conflict with prettier formatting.

Ansible-lint also does the same override for compatibility issues, especially as many users use format-on-save.

Reference: https://github.com/ansible/ansible-lint/blob/679ffc04c8ab84ee417cf6eec10868b06fc246eb/src/ansiblelint/yaml_utils.py#L52-L54


          Make yamllint rule compatible with prettier

e1697c2

Adapts yamllint config to not require two char indentation for
inline comments as that is in conflict with prettier formatting.

Ansible-lint also does the same override for compatibility issues,
especially as many users use format-on-save.

Reference: https://github.com/ansible/ansible-lint/blob/679ffc04c8ab84ee417cf6eec10868b06fc246eb/src/ansiblelint/yaml_utils.py#L52-L54

ssbarnea requested a review from a team as a code owner

July 19, 2022 13:20

github-actions bot added the needs_triage label

Akasurde removed the needs_triage label

Akasurde merged commit aa7c1ba into ansible:devel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment