[backport][2.2]update how callback plugin gets copied and added to job container #1098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sible#1093) when in containerized environment - always copy callback plugin to private_data_dir/artifacts/{job_id}/callback - appending to `ANSIBLE_CALLBACK_PLUGINS` with the runner callback plugin location (from private_data/artifacts) - unused method `utils.callback_mount` - update unit tests Co-authored-by: Alan Rominger <arominge@redhat.com> (cherry picked from commit 3b74385) Signed-off-by: Hao Liu <the.real.hao.liu@gmail.com>
|
This is a pretty major functional change for a backport to an already-released version of runner- not saying we shouldn't merge it, but it's definitely risky. |
eqrx
approved these changes
Jun 15, 2022
AlanCoding
approved these changes
Jun 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
back port of #1093 to release_2.2
when in containerized environment
Co-Authored-By: Alan Rominger arominge@redhat.com
Signed-off-by: Hao Liu the.real.hao.liu@gmail.com