Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport][2.2] update how callback plugin gets copied and added to job container #1097

Closed
wants to merge 8 commits into from

Conversation

TheRealHaoLiu
Copy link
Member

@TheRealHaoLiu TheRealHaoLiu commented Jun 15, 2022

back port of #1093 to release_2.2

when in containerized environment

  • always copy callback plugin to private_data_dir/artifacts/{job_id}/callback
  • appending to ANSIBLE_CALLBACK_PLUGINS with the runner callback plugin location (from private_data/artifacts)
  • unused method utils.callback_mount
  • update unit tests

Co-Authored-By: Alan Rominger arominge@redhat.com
Signed-off-by: Hao Liu the.real.hao.liu@gmail.com

Shrews and others added 8 commits May 2, 2022 14:26
…le#1039) (ansible#1052)

(cherry picked from commit c143c07)

Co-authored-by: Alan Rominger <arominge@redhat.com>
* Set ZIP strict_timestamps to false

Since python 3.8 timestamps before 1980 are disallowed by default,
but seem to occur in streams.

Fixes: awx#12126

Signed-off-by: Björn Pedersen <bjoern.pedersen@frm2.tum.de>

* Add test for timestamps before 1980

Co-authored-by: Alan Rominger <arominge@redhat.com>
(cherry picked from commit ec5997e)

Co-authored-by: Björn Pedersen <bjoern.pedersen@frm2.tum.de>
ansible#1062)

* override root homedir in /etc/passwd

* using only `HOME` envvar to override homedir causes mismatches with anything that asks for it a different way (eg, `echo ~root`)
* kicking the can down the road on "why are we overriding /root as root's homedir anyway?"

* more dynamic homedir handling

* just make everybody's home /home/runner

* restore ENV HOME override for builds

* comment wording

(cherry picked from commit c181daa)
correct way to check datatype of variable is `isinstance`

(cherry picked from commit a349921)

Signed-off-by: Abhijeet Kasurde <akasurde@redhddat.com>
…dler (ansible#1091)

Fixes: ansible#1078

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
…sible#1093)

when in containerized environment
- always copy callback plugin to private_data_dir/artifacts/{job_id}/callback
- appending to `ANSIBLE_CALLBACK_PLUGINS` with the runner callback plugin location (from private_data/artifacts)
- unused method `utils.callback_mount`
- update unit tests

Co-authored-by: Alan Rominger <arominge@redhat.com>
(cherry picked from commit 3b74385)
Signed-off-by: Hao Liu <the.real.hao.liu@gmail.com>
@TheRealHaoLiu TheRealHaoLiu requested a review from a team as a code owner June 15, 2022 13:50
@github-actions github-actions bot added docs Changes to documentation needs_triage New item that needs to be triaged labels Jun 15, 2022
@TheRealHaoLiu TheRealHaoLiu changed the title Backport/2.2/1093 [backport][2.2] update how callback plugin gets copied and added to job container Jun 15, 2022
@TheRealHaoLiu
Copy link
Member Author

forgot to pull before i cherry pick... closing

@TheRealHaoLiu TheRealHaoLiu deleted the backport/2.2/1093 branch June 15, 2022 13:53
@sivel sivel removed the needs_triage New item that needs to be triaged label May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Changes to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants