Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set ZIP strict_timestamps to false #1049

Merged
merged 3 commits into from May 3, 2022

Conversation

bpedersen2
Copy link
Contributor

Since python 3.8 timestamps before 1980 are disallowed by default,
but seem to occur in streams.

Fixes: awx#12126

Signed-off-by: Björn Pedersen bjoern.pedersen@frm2.tum.de

Since python 3.8 timestamps before 1980 are disallowed by default,
but seem to occur in streams.

Fixes: awx#12126

Signed-off-by: Björn Pedersen <bjoern.pedersen@frm2.tum.de>
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@bpedersen2
Copy link
Contributor Author

Hint: As python >=3.8 seems to be the minimum supported version we don't need a feature gate.

@AlanCoding
Copy link
Member

I wrote a test for this fix: bpedersen2#1

I confirmed that it fails with the error you give in the issue, and passes with your fix here. We would like to capture test coverage when merging something like this. If you merge that commit or add it manually, this will have my support to merge.

Add test for timestamps before 1980
@Shrews Shrews added the needs_triage New item that needs to be triaged label May 3, 2022
@eqrx eqrx removed the needs_triage New item that needs to be triaged label May 3, 2022
@Shrews Shrews merged commit ec5997e into ansible:devel May 3, 2022
Shrews pushed a commit to Shrews/ansible-runner that referenced this pull request May 3, 2022
* Set ZIP strict_timestamps to false

Since python 3.8 timestamps before 1980 are disallowed by default,
but seem to occur in streams.

Fixes: awx#12126

Signed-off-by: Björn Pedersen <bjoern.pedersen@frm2.tum.de>

* Add test for timestamps before 1980

Co-authored-by: Alan Rominger <arominge@redhat.com>
(cherry picked from commit ec5997e)
Shrews added a commit that referenced this pull request May 3, 2022
* Set ZIP strict_timestamps to false

Since python 3.8 timestamps before 1980 are disallowed by default,
but seem to occur in streams.

Fixes: awx#12126

Signed-off-by: Björn Pedersen <bjoern.pedersen@frm2.tum.de>

* Add test for timestamps before 1980

Co-authored-by: Alan Rominger <arominge@redhat.com>
(cherry picked from commit ec5997e)

Co-authored-by: Björn Pedersen <bjoern.pedersen@frm2.tum.de>
Shrews pushed a commit to Shrews/ansible-runner that referenced this pull request May 4, 2022
* Set ZIP strict_timestamps to false

Since python 3.8 timestamps before 1980 are disallowed by default,
but seem to occur in streams.

Fixes: awx#12126

Signed-off-by: Björn Pedersen <bjoern.pedersen@frm2.tum.de>

* Add test for timestamps before 1980

Co-authored-by: Alan Rominger <arominge@redhat.com>
(cherry picked from commit ec5997e)
Shrews added a commit that referenced this pull request May 4, 2022
Backport of PR #1049 

(cherry picked from commit ec5997e)
@weiyentan
Copy link

@bpedersen2 @AlanCoding how do we get these changes? In what tag did the fix come in?
I used this image in my AWX environment
EE_BASE_IMAGE: 'quay.io/ansible/ansible-runner:stable-2.12-latest' and i am still getting this error when having contents in my collections.

@jinja2ninja
Copy link

I'm getting the same issue as @weiyentan on stable-2.12-devel

@weiyentan
Copy link

@fahcsim i am testing with 21

@Shrews
Copy link
Contributor

Shrews commented May 31, 2022

FYI, the images on quay.io are not being updated, at the moment. We are working on a new container image release pipeline, which will likely include a new image tagging scheme. We ask for patience while we develop this process, which we hope to have finished soon. In the meantime, it is easy enough to build your own image based on the current release. For the 2.2 release, something along the lines of:

git clone https://github.com/ansible/ansible-runner.git
git checkout -b release_2.2 origin/release_2.2
docker build -t my_tag_name .

Use the release_2.1 branch if you prefer that release.

@weiyentan
Copy link

Thank you for your confirmation. What will set need to change in the image?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants