New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set ZIP strict_timestamps to false #1049
Conversation
Since python 3.8 timestamps before 1980 are disallowed by default, but seem to occur in streams. Fixes: awx#12126 Signed-off-by: Björn Pedersen <bjoern.pedersen@frm2.tum.de>
Build succeeded.
|
Hint: As python >=3.8 seems to be the minimum supported version we don't need a feature gate. |
I wrote a test for this fix: bpedersen2#1 I confirmed that it fails with the error you give in the issue, and passes with your fix here. We would like to capture test coverage when merging something like this. If you merge that commit or add it manually, this will have my support to merge. |
Add test for timestamps before 1980
* Set ZIP strict_timestamps to false Since python 3.8 timestamps before 1980 are disallowed by default, but seem to occur in streams. Fixes: awx#12126 Signed-off-by: Björn Pedersen <bjoern.pedersen@frm2.tum.de> * Add test for timestamps before 1980 Co-authored-by: Alan Rominger <arominge@redhat.com> (cherry picked from commit ec5997e)
* Set ZIP strict_timestamps to false Since python 3.8 timestamps before 1980 are disallowed by default, but seem to occur in streams. Fixes: awx#12126 Signed-off-by: Björn Pedersen <bjoern.pedersen@frm2.tum.de> * Add test for timestamps before 1980 Co-authored-by: Alan Rominger <arominge@redhat.com> (cherry picked from commit ec5997e) Co-authored-by: Björn Pedersen <bjoern.pedersen@frm2.tum.de>
* Set ZIP strict_timestamps to false Since python 3.8 timestamps before 1980 are disallowed by default, but seem to occur in streams. Fixes: awx#12126 Signed-off-by: Björn Pedersen <bjoern.pedersen@frm2.tum.de> * Add test for timestamps before 1980 Co-authored-by: Alan Rominger <arominge@redhat.com> (cherry picked from commit ec5997e)
@bpedersen2 @AlanCoding how do we get these changes? In what tag did the fix come in? |
I'm getting the same issue as @weiyentan on stable-2.12-devel |
@fahcsim i am testing with 21 |
FYI, the images on quay.io are not being updated, at the moment. We are working on a new container image release pipeline, which will likely include a new image tagging scheme. We ask for patience while we develop this process, which we hope to have finished soon. In the meantime, it is easy enough to build your own image based on the current release. For the
Use the |
Thank you for your confirmation. What will set need to change in the image? |
Since python 3.8 timestamps before 1980 are disallowed by default,
but seem to occur in streams.
Fixes: awx#12126
Signed-off-by: Björn Pedersen bjoern.pedersen@frm2.tum.de