Adding --omit-env-files option #1000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanemcd
reviewed
Feb 16, 2022
john-westcott-iv
force-pushed
the
store_env
branch
2 times, most recently
from
0989679
to
7098fc3
Compare
john-westcott-iv
added a commit
to john-westcott-iv/awx
that referenced
this pull request
Feb 17, 2022
john-westcott-iv
force-pushed
the
store_env
branch
3 times, most recently
from
10bf09f
to
aa853c6
Compare
…sswords for sensitive reason
john-westcott-iv
force-pushed
the
store_env
branch
from
aa853c6
to
05ee079
Compare
john-westcott-iv
added a commit
to john-westcott-iv/awx
that referenced
this pull request
Feb 21, 2022
john-westcott-iv
added a commit
to john-westcott-iv/awx
that referenced
this pull request
Feb 23, 2022
john-westcott-iv
changed the title
shanemcd
approved these changes
Mar 1, 2022
Shrews
approved these changes
Mar 1, 2022
AlanCoding
pushed a commit
to AlanCoding/awx
that referenced
this pull request
Mar 1, 2022
john-westcott-iv
added a commit
to john-westcott-iv/awx
that referenced
this pull request
Mar 2, 2022
john-westcott-iv
added a commit
to john-westcott-iv/awx
that referenced
this pull request
Mar 8, 2022
john-westcott-iv
added a commit
to john-westcott-iv/ansible-runner
that referenced
this pull request
Mar 14, 2022
Adding --omit-env-files option Adding an option to not write out files into the env folder as these can contain sensitive information. Changing write fifo to take either bytes or a string. Initially based off of ansible#812 Reviewed-by: Shane McDonald <me@shanemcd.com> Reviewed-by: John Westcott IV <None> Reviewed-by: David Shrewsbury <None>
john-westcott-iv
added a commit
to john-westcott-iv/awx
that referenced
this pull request
Mar 14, 2022
ansible-zuul bot
pushed a commit
that referenced
this pull request
Mar 16, 2022
[2.1] [backport] Adding --omit-env-files Back porting #1000 to 2.1 branch. Adding --omit-env-files option Adding an option to not write out files into the env folder as these can contain sensitive information. Changing write fifo to take either bytes or a string. Initially based off of #812 Reviewed-by: Shane McDonald me@shanemcd.com Reviewed-by: John Westcott IV Reviewed-by: David Shrewsbury Reviewed-by: Shane McDonald <me@shanemcd.com>
john-westcott-iv
added a commit
to john-westcott-iv/awx
that referenced
this pull request
Apr 8, 2022
john-westcott-iv
added a commit
to john-westcott-iv/awx
that referenced
this pull request
Apr 14, 2022
john-westcott-iv
added a commit
to john-westcott-iv/awx
that referenced
this pull request
Apr 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding an option to not write out files into the env folder as these can contain sensitive information.
Changing write fifo to take either bytes or a string.
Initially based off of #812