Make sure we close stdout/stderr in Runner.run() #1123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shrews
changed the title
eqrx
reviewed
Sep 6, 2022
eqrx
approved these changes
Sep 6, 2022
Shrews
added a commit
to Shrews/ansible-runner
that referenced
this pull request
Sep 7, 2022
* Make sure we close stdout/stderr * Remove unnecessary flush() calls (cherry picked from commit 2eab201)
Shrews
added a commit
to Shrews/ansible-runner
that referenced
this pull request
Sep 7, 2022
* Make sure we close stdout/stderr * Remove unnecessary flush() calls (cherry picked from commit 2eab201)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we treat warnings as errors with pytest (via
-Werroror config file change), tests usingsubprocesscode path will fail because we get a warning about an unclosed file onstderr.Ultimately, the entire
Runner.run()method probably needs reworked so that it is not so complex, and we can use better/safer coding methods, such as context managers on the open file handles. As it is now, using context managers on these file handles is a major pain since there is so much code between opening them and where we need to guarantee they are closed.Provided test will fail without the code changes to close
stdout/stderr.