Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unclosed file warnings #1124

Closed
Shrews opened this issue Aug 25, 2022 · 4 comments
Closed

Fix unclosed file warnings #1124

Shrews opened this issue Aug 25, 2022 · 4 comments
Labels
bug Something isn't working

Comments

@Shrews
Copy link
Contributor

Shrews commented Aug 25, 2022 •
edited

Using the -Werror flag to pytest in our unit tests reveals that there are places in the code where we do not properly close open file handles (.e.g., ResourceWarning: unclosed file ...). We should investigate and fix those.

See PR #1123 as an example fix.
@github-actions github-actions bot added the needs_triage New item that needs to be triaged label Aug 25, 2022
@eqrx eqrx removed the needs_triage New item that needs to be triaged label Sep 6, 2022
@Akasurde

This comment was marked as outdated.

Sign in to view
@Akasurde Akasurde closed this as completed Sep 8, 2022
@Akasurde Akasurde added the enhancement New feature or request label Sep 8, 2022
@Shrews
Copy link
Contributor Author

Shrews commented Sep 8, 2022

Reopening this. Referenced PR #1123 only fixes one code path producing this warning. Turning on -Werror for all unit tests will reveal similar warnings that we need to investigate.

@Shrews Shrews reopened this Sep 8, 2022
@Shrews Shrews removed their assignment Sep 8, 2022
@github-actions github-actions bot added the needs_triage New item that needs to be triaged label Sep 8, 2022
@Akasurde Akasurde added bug Something isn't working and removed enhancement New feature or request needs_triage New item that needs to be triaged labels Sep 8, 2022
@Akasurde
Copy link
Member

Akasurde commented Sep 8, 2022

@Shrews my bad.

@Akasurde
Copy link
Member

resolved_by_pr #1228

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Akasurde @Shrews @eqrx