New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
skip process isolation check for transmit and process #1084
skip process isolation check for transmit and process #1084
Conversation
e2d29e5
to
961c7f1
Compare
ansible_runner/interface.py
Outdated
@@ -83,7 +83,7 @@ def init_runner(**kwargs): | |||
if logfile: | |||
output.set_logfile(logfile) | |||
|
|||
if kwargs.get("process_isolation", False): | |||
if kwargs.get("process_isolation", False) and kwargs.get("streamer") not in ('transmit', 'process'): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have this in my PR also: https://github.com/ansible/ansible-runner/pull/1079/files#diff-179ccecedba1c6ccf73b8c02f0321b252c018226e41ce82887a93ace762d2fbbR55
This line causes an astonishing amount of problems when interfacing with Runner from the CLI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the reason it does this has to do with the rest of my PR, which is that the CLI entrypoint clashes with the module level entrypoint when managing process isolation paths.
My work on #1079 focuses on realigning those two paths.
Fix that vscode comment and then I think we should merge this asap. |
5db7742
to
0f12e05
Compare
|
8c70756
to
7083535
Compare
code change after peer programing with @jbradberry moved the location of the check |
7083535
to
612216e
Compare
moving down the process isolation executable so that transmit and process no longer checks for its existance ansible-runner worker will still run the check since it will invoke ansible-runner run with process-isolation-executable and it will still be checked properly Co-Authored-By: Jeff Bradberry <685957+jbradberry@users.noreply.github.com> Signed-off-by: Hao Liu <haoli@redhat.com>
612216e
to
5370620
Compare
Manually tested this to verify that |
0324646
to
0e67829
Compare
testcase added |
pull change from - ansible#1084 - ansible#1089
""" | ||
def mock_check_isolation_executable_installed(executable): | ||
if executable == "exist": | ||
return True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return True | |
return True | |
return False |
0e67829
to
a5e5aba
Compare
testcase commit amended base on @Shrews's feedback |
test_process_isolation_executable_not_exist will validate that - transmit will run when process isolation executable missing and properly pass on the related kwargs to the output - worker will fail with sys.exit(1) when process isolation executable missiing Signed-off-by: Hao Liu <haoli@redhat.com>
a5e5aba
to
696f7a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! If you want this in any of the previously released 2.x versions, you'll need to supply a backport to the appropriate release branches. We follow the same basic backport process as Ansible (https://docs.ansible.com/ansible/latest/community/development_process.html#backport-process).
no need for backport thanks |
* skip process isolation check for transmit and process moving down the process isolation executable so that transmit and process no longer checks for its existance ansible-runner worker will still run the check since it will invoke ansible-runner run with process-isolation-executable and it will still be checked properly Co-Authored-By: Jeff Bradberry <685957+jbradberry@users.noreply.github.com> Signed-off-by: Hao Liu <haoli@redhat.com>
backport to 2.2 #1094 |
* skip process isolation check for transmit and process moving down the process isolation executable so that transmit and process no longer checks for its existance ansible-runner worker will still run the check since it will invoke ansible-runner run with process-isolation-executable and it will still be checked properly Co-Authored-By: Jeff Bradberry <685957+jbradberry@users.noreply.github.com> Signed-off-by: Hao Liu <haoli@redhat.com> Co-authored-by: Jeff Bradberry <685957+jbradberry@users.noreply.github.com>
#1085