Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

while running via the transmit-worker-process, ansible-runner should only check process isolation exec for worker #1085

Closed
TheRealHaoLiu opened this issue Jun 1, 2022 · 0 comments · Fixed by #1084

Comments

@TheRealHaoLiu
Copy link
Member

When trying to run job via transmit-worker-process while using process_isolation_executable the kwargs pass into
transmit will contain the process_isolation=true this cause check_isolation_executable_installed to run during all 3 of the phases (transmit, worker, process)

if kwargs.get("process_isolation", False):
pi_executable = kwargs.get("process_isolation_executable", "podman")
if not check_isolation_executable_installed(pi_executable):
print(f'Unable to find process isolation executable: {pi_executable}')
sys.exit(1)

In order for the transmit-worker-process chain to use process_isolation_executable the argument must be passed to transmit and have transmit pass the argument down the chain. Therefore we can not just simply remove the argument.

In AWX ansible-runner transmit runs on host that dispatcher runs while ansible-runner worker runs on host that the receptor runs

It is possible for the host for dispatcher does not have the process_isolation_executable (since the job is not actually run on the host) and only the host for receptor have the process_isolation_executable

https://github.com/ansible/awx/blob/4dc956c76f31accc3f57599d5e6df1735ffa2c16/awx/main/tasks/receptor.py#L391

@github-actions github-actions bot added the needs_triage New item that needs to be triaged label Jun 1, 2022
@Shrews Shrews linked a pull request Jun 7, 2022 that will close this issue
@Shrews Shrews closed this as completed Jun 7, 2022
@sivel sivel removed the needs_triage New item that needs to be triaged label May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants