Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable testing with devel branches #1489

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Enable testing with devel branches #1489

wants to merge 3 commits into from

Conversation

ssbarnea
Copy link
Member

No description provided.

@github-actions github-actions bot added the bug Researched, reproducible, committed to fix label Apr 19, 2023
@ssbarnea ssbarnea mentioned this pull request Apr 19, 2023
Closed
@ssbarnea ssbarnea marked this pull request as ready for review April 19, 2023 15:43
@ssbarnea
Copy link
Member Author

@shatakshiiii This PR proves the fact that navigator cannot be tested with unreleased versions of ansible-lint, even if these versions are not really breaking anything.

This uncovered the fact that navigator testing implementation is too fragile and needs to be refactored to allow this kind of testing.

@shatakshiiii
Copy link
Contributor

shatakshiiii commented Sep 21, 2023 •
edited

@shatakshiiii This PR proves the fact that navigator cannot be tested with unreleased versions of ansible-lint, even if these versions are not really breaking anything.

This uncovered the fact that navigator testing implementation is too fragile and needs to be refactored to allow this kind of testing.

@ssbarnea As far as I understand we are only trying to add devel job to check against unreleased versions of ansible-core and ansible-builder in this PR (not ansible-lint).

@shatakshiiii shatakshiiii temporarily deployed to ack September 21, 2023 12:51 — with GitHub Actions Inactive
@cidrblock
Copy link
Collaborator

@shatakshiiii is correct, we can do a follow up PR for lint from the main branch later.

@shatakshiiii shatakshiiii temporarily deployed to ack September 21, 2023 14:40 — with GitHub Actions Inactive
@ssbarnea ssbarnea temporarily deployed to ack October 4, 2023 13:06 — with GitHub Actions Inactive
@ssbarnea ssbarnea temporarily deployed to test October 4, 2023 13:06 — with GitHub Actions Inactive
@ssbarnea ssbarnea temporarily deployed to test October 4, 2023 13:06 — with GitHub Actions Inactive
@ssbarnea ssbarnea temporarily deployed to test October 4, 2023 13:07 — with GitHub Actions Inactive
@ssbarnea ssbarnea temporarily deployed to test October 4, 2023 13:07 — with GitHub Actions Inactive
@shatakshiiii shatakshiiii marked this pull request as draft October 30, 2023 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cidrblock cidrblock Awaiting requested review from cidrblock

@cristianonicolai cristianonicolai Awaiting requested review from cristianonicolai cristianonicolai was automatically assigned from ansible/devtools

@priyamsahoo priyamsahoo Awaiting requested review from priyamsahoo priyamsahoo was automatically assigned from ansible/devtools

@shatakshiiii shatakshiiii Awaiting requested review from shatakshiiii shatakshiiii was automatically assigned from ansible/devtools

At least 1 approving review is required to merge this pull request.

Assignees

@shatakshiiii shatakshiiii

Labels
bug Researched, reproducible, committed to fix
Projects
🧰 devtools project board
Status: Roadmap
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ssbarnea @shatakshiiii @cidrblock