Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combine form presenter with form #1161

Merged
merged 5 commits into from
Mar 30, 2022
Merged

Combine form presenter with form #1161

merged 5 commits into from
Mar 30, 2022

Conversation

cidrblock
Copy link
Collaborator

@cidrblock cidrblock commented Mar 30, 2022 •
edited

This will eliminate the circular dependency, FormPresenter is only used by Form.

The circular dep was in form_presenter and also had an "if TYPE_CHECKING" for the same reason.

This will also help eliminate some sphinx errors found in #1160

@cidrblock cidrblock requested review from a team, relrod, ssbarnea, webknjaz and ganeshrn March 30, 2022 13:50
@cidrblock cidrblock mentioned this pull request Mar 30, 2022
Merged
@cidrblock cidrblock self-assigned this Mar 30, 2022
@cidrblock cidrblock merged commit 1618d37 into ansible:main Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@relrod relrod relrod approved these changes

@ssbarnea ssbarnea Awaiting requested review from ssbarnea ssbarnea was automatically assigned from ansible/devtools

@webknjaz webknjaz Awaiting requested review from webknjaz webknjaz was automatically assigned from ansible/devtools

@ganeshrn ganeshrn Awaiting requested review from ganeshrn

Assignees

@cidrblock cidrblock

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cidrblock @relrod