Enable annotations on failed tests #910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webknjaz
reviewed
Jul 22, 2020
webknjaz
reviewed
Jul 22, 2020
webknjaz
reviewed
Jul 22, 2020
webknjaz
reviewed
Jul 22, 2020
webknjaz
reviewed
Jul 22, 2020
webknjaz
reviewed
Jul 22, 2020
webknjaz
reviewed
Jul 22, 2020
webknjaz
reviewed
Jul 22, 2020
webknjaz
reviewed
Jul 23, 2020
|
@ssbarnea it works with |
webknjaz
reviewed
Jul 24, 2020
webknjaz
reviewed
Jul 24, 2020
.github/workflows/tox.yml
Outdated
| @@ -179,6 +179,11 @@ jobs: | |||
| with: | |||
| name: logs.zip | |||
| path: .tox/**/log/ | |||
| - name: Report junit failures | |||
| uses: shyim/junit-report-annotations-action@master | |||
There was a problem hiding this comment.
I'm not sure about using master. Should we wait till shyim/junit-report-annotations-action#3 (comment) gets addressed and pin it then?
There was a problem hiding this comment.
Is ok, the risk is very low. The token is read-only.
There was a problem hiding this comment.
My concern is not (only) about that:
- The action may suddenly break the interface.
- The token only has read-only mode for PR runs, there's still cron runs and tag creations that will run in-repo and have higher privileges.
webknjaz
reviewed
Jul 24, 2020
Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
webknjaz
approved these changes
Jul 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP: Currently waiting for shyim/junit-report-annotations-action#3 fixes.