Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for ANSIBLE_VAULT_PASSWORD_FILE #4069

Conversation

AsharLohmar
Copy link

@AsharLohmar AsharLohmar commented Mar 13, 2024

Ported some code from ansible.cli so that the DataLoaders would have access to vault secrets when the ANSIBLE_VAULT_PASSWORD_FILE ENV var is set.
Vault ids are not supported.
The idea was to help with the #115

@AsharLohmar AsharLohmar requested a review from a team as a code owner March 13, 2024 15:21
@AsharLohmar AsharLohmar requested review from ssbarnea and Qalthos and removed request for a team March 13, 2024 15:21
@ssbarnea
Copy link
Member

ssbarnea commented Apr 8, 2024

I converted it to draft due to lack of test coverage.

@AsharLohmar
Copy link
Author

It's my first PR so I'm not good with all this stuff.
I've "seen a need" (because I was annoyed by those messages too) and found a "solution", by porting (copying) the code from the ansible cli. Seen that it was a matter of just a few lines of code, I thought that even if this doesn't go through at least maybe someone will find enough to do it properly. That's also the reason I ported the code in the exact same form (as much as possible) as I found it where I found it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

3 participants