Add details of interactions between notifications and loops #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This clarifies behaviour raised in ansible/ansible#81950 and ansible/ansible#77550 as expected and documented.
github-actions
bot
added
the
needs_triage
gotmax23
added
the
new_contributor
gotmax23
reviewed
Oct 13, 2023
gotmax23
added
backport-2.15
|
@lod, are you still interested in proceeding with this PR? |
Co-authored-by: Maxwell G <maxwell@gtmx.me>
samccann
removed
needs_info
|
@gotmax23 - i committed your suggested edits. Can you take another look and approve the PR if you agree? |
| state: restarted | ||
|
|
||
| Note that the handlers are triggered if the task as a whole is changed, for loops that is if any loop item changes. | ||
| In the above example both memcached and apache will be restarted if either template file is changed, neither will be restarted if no file changes. |
There was a problem hiding this comment.
Since this behavior is pretty surprising (at least to me, and apparently also to the folks who created the issues in ansible/ansible) I would suggest moving this paragraph before the example, so that you read this before looking at the example. Right now when starting to read this new section, I might just look at the first paragraph and then at the example and then stop, getting the completely wrong impression of what is happening.
| ansible.builtin.template: | ||
| src: "{{ item }}.j2" | ||
| dest: /etc/systemd/system/{{ item }}.service | ||
| notify: Restart {{ item }} |
There was a problem hiding this comment.
I would also add a comment inside the example, like this:
Suggested change
| notify: Restart {{ item }} | |
| # Note: if *any* loop iteration triggers a change, *all* handlers | |
| # for this loop are run! | |
| notify: Restart {{ item }} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This clarifies behaviour raised in ansible/ansible#81950 and ansible/ansible#77550 as expected and documented.