Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release table for 2.17 #1426

Merged
merged 1 commit into from May 15, 2024
Merged

Update release table for 2.17 #1426

merged 1 commit into from May 15, 2024

Conversation

samccann
Copy link
Contributor

@samccann samccann commented May 9, 2024

Part of #1249

Can be merged and then backport to 2.17 only.

@samccann samccann added the backport-2.17 Automatically create a backport for the stable-2.17 branch label May 9, 2024
Copy link
Contributor

@oraNod oraNod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like it should be two separate PRs. Also where can you verify the Powershell range?

@samccann
Copy link
Contributor Author

Both changes are 'get release and maint table ready for release'. I woudn't want to open separate PRs for this.

As for powershell, the answer is ask core folks :-) I don't know if there is a place in core code where this is obvious.

@oraNod
Copy link
Contributor

oraNod commented May 15, 2024

Both changes are 'get release and maint table ready for release'. I woudn't want to open separate PRs for this.

As for powershell, the answer is ask core folks :-) I don't know if there is a place in core code where this is obvious.

OK, it just reads like two distinct changes so I guess my reflex to keep it atomic was triggered.

I had a quick scan through the core repo to see if maybe the powershell versions were in a test matrix or something but didn't have any luck. Given that it doesn't seem possible to verify the versions in code should we require core team approval here to be on the safe side?

@samccann samccann changed the title Add changelog link and update powershell range Update release table for 2.17 May 15, 2024
@samccann samccann requested a review from sivel May 15, 2024 14:28
@samccann samccann added the core_approval This PR requires approval from the Ansible Core team label May 15, 2024
@samccann
Copy link
Contributor Author

Okay I changed the PR title to make it obvious what the driving factor in the changes are.

@sivel can you give a quick review/approval?

@oraNod oraNod merged commit 1153c4e into ansible:devel May 15, 2024
8 checks passed
Copy link

patchback bot commented May 15, 2024

Backport to stable-2.17: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-2.17/1153c4e91e2f1b539986d0bcc35204f739490cd7/pr-1426

Backported as #1461

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request May 15, 2024
Update release table for 2.17

(cherry picked from commit 1153c4e)
@oraNod
Copy link
Contributor

oraNod commented May 15, 2024

Thanks @samccann and @sivel

oraNod added a commit that referenced this pull request May 15, 2024
…/1153c4e91e2f1b539986d0bcc35204f739490cd7/pr-1426

[PR #1426/1153c4e9 backport][stable-2.17] Update release table for 2.17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-2.17 Automatically create a backport for the stable-2.17 branch core_approval This PR requires approval from the Ansible Core team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants