Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MUNI Tech Writers: Timeout with retry in loops documentation #1416

Merged
merged 7 commits into from May 17, 2024
Merged

MUNI Tech Writers: Timeout with retry in loops documentation #1416

merged 7 commits into from May 17, 2024

Conversation

sourn00dl
Copy link

Rebase from old PR #1282 which was made in a wrong branch.
Resolving issue #881

@ansible-documentation-bot ansible-documentation-bot bot added the new_contributor This PR is the first contribution by a new community member. label May 6, 2024
@ansible-documentation-bot
Copy link
Contributor

Thanks for your Ansible docs contribution! We talk about Ansible documentation on matrix at #docs:ansible.im and on libera IRC at #ansible-docs if you ever want to join us and chat about the docs! We meet there on Tuesdays (see the Ansible calendar) and welcome additions to our weekly agenda items - scroll down to find the upcoming agenda and add a comment to put something new on that agenda.

@sourn00dl sourn00dl mentioned this pull request May 6, 2024
Closed
@samccann
Copy link
Contributor

samccann commented May 7, 2024

closing and reopening to fix CI issues

@samccann samccann closed this May 7, 2024
@samccann samccann reopened this May 7, 2024
@samccann
Copy link
Contributor

samccann commented May 9, 2024

Thanks for the rebase @sourn00dl . I think there may be a a few comments still to fix based on #1282...

@sourn00dl
Copy link
Author

@samccann Could you please specify which comments you're referring to? I just want to make sure I address the issues correctly, thank you!

@oraNod oraNod added backport-2.15 Automatically create a backport for the stable-2.15 branch backport-2.14 Automatically create a backport for the stable-2.14 branch backport-2.16 Automatically create a backport for the stable-2.16 branch MUNI tech writers backport-2.17 Automatically create a backport for the stable-2.17 branch labels May 13, 2024
oraNod
oraNod reviewed May 14, 2024
View reviewed changes
Copy link
Contributor

@oraNod oraNod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one @sourn00dl Thanks for sticking with it! Some suggestions and comments for you.

docs/docsite/rst/playbook_guide/playbooks_loops.rst Outdated Show resolved Hide resolved
docs/docsite/rst/playbook_guide/playbooks_loops.rst Outdated Show resolved Hide resolved
docs/docsite/rst/playbook_guide/playbooks_loops.rst Outdated Show resolved Hide resolved
@samccann
Copy link
Contributor

@sourn00dl I think the only open comment not addressed in the old PR is part of @oraNod's comments here. Thanks!

oraNod
oraNod approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@oraNod oraNod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sourn00dl I pushed some changes to your branch. Thanks again for all the hard work on this issue! 🎉

@oraNod oraNod requested review from bcoca and samccann May 17, 2024 09:57
@oraNod
Copy link
Contributor

oraNod commented May 17, 2024

Companion changes to the TIMEOUT keyword updates in ansible/ansible#83152

@oraNod oraNod requested a review from s-hertel May 17, 2024 09:58
@oraNod oraNod merged commit b42de8c into ansible:devel May 17, 2024
8 checks passed
@patchback Patchback
Copy link

patchback bot commented May 17, 2024 •
edited

Backport to stable-2.15: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-2.15/b42de8c0179c14a3d4601d36c903a27f0387fc36/pr-1416

Backported as #1473

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@oraNod
Copy link
Contributor

oraNod commented May 17, 2024

Thanks again for the contribution to the docs @sourn00dl

patchback bot pushed a commit that referenced this pull request May 17, 2024
@oraNod @patchback
Merge pull request #1416 from sourn00dl/feature#881
46bbc7d 
MUNI Tech Writers: Timeout with retry in loops documentation

(cherry picked from commit b42de8c)
@patchback patchback bot mentioned this pull request May 17, 2024
Merged
@patchback Patchback
Copy link

patchback bot commented May 17, 2024 •
edited

Backport to stable-2.14: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-2.14/b42de8c0179c14a3d4601d36c903a27f0387fc36/pr-1416

Backported as #1474

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request May 17, 2024
@oraNod @patchback
Merge pull request #1416 from sourn00dl/feature#881
71c481e 
MUNI Tech Writers: Timeout with retry in loops documentation

(cherry picked from commit b42de8c)
@patchback patchback bot mentioned this pull request May 17, 2024
Merged
@patchback Patchback
Copy link

patchback bot commented May 17, 2024 •
edited

Backport to stable-2.16: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-2.16/b42de8c0179c14a3d4601d36c903a27f0387fc36/pr-1416

Backported as #1475

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request May 17, 2024
@oraNod @patchback
Merge pull request #1416 from sourn00dl/feature#881
50d92b7 
MUNI Tech Writers: Timeout with retry in loops documentation

(cherry picked from commit b42de8c)
@patchback patchback bot mentioned this pull request May 17, 2024
Merged
@patchback Patchback
Copy link

patchback bot commented May 17, 2024 •
edited

Backport to stable-2.17: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-2.17/b42de8c0179c14a3d4601d36c903a27f0387fc36/pr-1416

Backported as #1476

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request May 17, 2024
@oraNod @patchback
Merge pull request #1416 from sourn00dl/feature#881
89f6952 
MUNI Tech Writers: Timeout with retry in loops documentation

(cherry picked from commit b42de8c)
@patchback patchback bot mentioned this pull request May 17, 2024
Merged
oraNod added a commit that referenced this pull request May 17, 2024
@oraNod
Merge pull request #1473 from ansible/patchback/backports/stable-2.15…
2f0666d 
…/b42de8c0179c14a3d4601d36c903a27f0387fc36/pr-1416

[PR #1416/b42de8c0 backport][stable-2.15] MUNI Tech Writers: Timeout with retry in loops documentation
oraNod added a commit that referenced this pull request May 17, 2024
@oraNod
Merge pull request #1474 from ansible/patchback/backports/stable-2.14…
512a785 
…/b42de8c0179c14a3d4601d36c903a27f0387fc36/pr-1416

[PR #1416/b42de8c0 backport][stable-2.14] MUNI Tech Writers: Timeout with retry in loops documentation
oraNod added a commit that referenced this pull request May 17, 2024
@oraNod
Merge pull request #1475 from ansible/patchback/backports/stable-2.16…
ef8efe0 
…/b42de8c0179c14a3d4601d36c903a27f0387fc36/pr-1416

[PR #1416/b42de8c0 backport][stable-2.16] MUNI Tech Writers: Timeout with retry in loops documentation
oraNod added a commit that referenced this pull request May 17, 2024
@oraNod
Merge pull request #1476 from ansible/patchback/backports/stable-2.17…
2881fd5 
…/b42de8c0179c14a3d4601d36c903a27f0387fc36/pr-1416

[PR #1416/b42de8c0 backport][stable-2.17] MUNI Tech Writers: Timeout with retry in loops documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s-hertel s-hertel s-hertel approved these changes

@oraNod oraNod oraNod approved these changes

@bcoca bcoca Awaiting requested review from bcoca

@samccann samccann Awaiting requested review from samccann

Assignees
No one assigned
Labels
backport-2.14 Automatically create a backport for the stable-2.14 branch backport-2.15 Automatically create a backport for the stable-2.15 branch backport-2.16 Automatically create a backport for the stable-2.16 branch backport-2.17 Automatically create a backport for the stable-2.17 branch MUNI tech writers new_contributor This PR is the first contribution by a new community member.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sourn00dl @samccann @oraNod @s-hertel