Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documented plugin documentation on documenting #1219

Open
wants to merge 1 commit into
base: devel
Choose a base branch
from

Conversation

bcoca
Copy link
Member

@bcoca bcoca commented Mar 19, 2024

Cause it is similar but NOT the same as modules

Copy link
Contributor

@oraNod oraNod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bcoca LGTM

@felixfontein
Copy link
Collaborator

This is replicating quite some content from the other document, like details of semantic markup, which we should clean up and move to a single place after merging this (or before, idk).

docs/docsite/rst/dev_guide/plugins_documenting.rst Outdated Show resolved Hide resolved
docs/docsite/rst/dev_guide/plugins_documenting.rst Outdated Show resolved Hide resolved
docs/docsite/rst/dev_guide/plugins_documenting.rst Outdated Show resolved Hide resolved
docs/docsite/rst/dev_guide/plugins_documenting.rst Outdated Show resolved Hide resolved
docs/docsite/rst/dev_guide/plugins_documenting.rst Outdated Show resolved Hide resolved
docs/docsite/rst/dev_guide/plugins_documenting.rst Outdated Show resolved Hide resolved
docs/docsite/rst/dev_guide/plugins_documenting.rst Outdated Show resolved Hide resolved
docs/docsite/rst/dev_guide/plugins_documenting.rst Outdated Show resolved Hide resolved
@ansible-documentation-bot ansible-documentation-bot bot added the sc_approval This PR requires approval from the Ansible Community Steering Committee label Mar 20, 2024
@bcoca
Copy link
Member Author

bcoca commented Mar 20, 2024

not sure which toctree to add this to so it passes tests, also weird since i don't see module_documentation in any toctree either.

@bcoca
Copy link
Member Author

bcoca commented Mar 21, 2024

felixfontein I agree, i remember discussing a 'shared snippet' infrastructure, but I don't know if or how it got implemented.

@bcoca bcoca marked this pull request as ready for review March 21, 2024 23:06
@bcoca bcoca requested a review from a team as a code owner March 21, 2024 23:06
@bcoca
Copy link
Member Author

bcoca commented Mar 21, 2024

duh, sphinx already supports:

.. include:: ../shared/folder/filename.rst

Apply suggestions from code review
Move some comment to 'common snippet' to be included in both plugin and module pages

Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sc_approval This PR requires approval from the Ansible Community Steering Committee
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants