New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
documented plugin documentation on documenting #1219
base: devel
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bcoca LGTM
This is replicating quite some content from the other document, like details of semantic markup, which we should clean up and move to a single place after merging this (or before, idk). |
docs/docsite/rst/dev_guide/developing_collections_documenting.rst
Outdated
Show resolved
Hide resolved
not sure which toctree to add this to so it passes tests, also weird since i don't see module_documentation in any toctree either. |
felixfontein I agree, i remember discussing a 'shared snippet' infrastructure, but I don't know if or how it got implemented. |
duh, sphinx already supports:
|
Apply suggestions from code review Move some comment to 'common snippet' to be included in both plugin and module pages Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com>
ab01908
to
1a62371
Compare
Cause it is similar but NOT the same as modules