Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup some developer config #171

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Cleanup some developer config #171

wants to merge 5 commits into from

Conversation

cidrblock
Copy link
Collaborator

@cidrblock cidrblock commented May 3, 2024 •
edited

  • Update the exception list for pylint
  • Cleanup the vscode settings file
  • Add developer tools to requirements-test
  • Remove duplicate info from vscode settings file

@cidrblock cidrblock requested review from NilashishC and a team as code owners May 3, 2024 18:54
@cidrblock cidrblock requested review from Qalthos and priyamsahoo and removed request for a team May 3, 2024 18:54
@github-actions github-actions bot added the skip-changelog Skip changelog check when this label is found. label May 3, 2024
ssbarnea
ssbarnea requested changes May 7, 2024
View reviewed changes
Copy link
Member

@ssbarnea ssbarnea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have a requirements-test.in file and we do not want to use different names between our project.

@cidrblock cidrblock requested a review from ssbarnea May 7, 2024 14:28
@cidrblock cidrblock marked this pull request as draft May 13, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NilashishC NilashishC Awaiting requested review from NilashishC NilashishC is a code owner

@Qalthos Qalthos Awaiting requested review from Qalthos Qalthos is a code owner automatically assigned from ansible/devtools

@priyamsahoo priyamsahoo Awaiting requested review from priyamsahoo priyamsahoo is a code owner automatically assigned from ansible/devtools

@ssbarnea ssbarnea Awaiting requested review from ssbarnea

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
skip-changelog Skip changelog check when this label is found.
Projects
🧰 devtools project board
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cidrblock @ssbarnea