Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup.py: avoid using recursive globs for package_data #520

Merged
merged 2 commits into from May 1, 2023

Conversation

felixfontein
Copy link
Collaborator

These are only supported since setuptools 62.3.0 (https://github.com/pypa/setuptools/blob/main/CHANGES.rst#v6230) (see pypa/setuptools#1806 for details).

@felixfontein
Copy link
Collaborator Author

I haven't been able to test this yet, since every single time I try to build Ansible, downloading ansible-core (for the combined changelog) ends up with a TimeoutError (most likely due to my internet connection at the moment). I'll probably have to rip some code out to see whether this works...

@felixfontein
Copy link
Collaborator Author

I've now been able to test this (with some out-commented code), and it seems to work well - even better than before, now ansible_collections-new/cyberark/conjur/roles/conjur_host_identity/tests/.pytest_cache/ is included as it should (except that this directory shouldn't have been there in the first place, but that's another story). The downside is that setup.py now has almost 3300 lines...

@felixfontein felixfontein marked this pull request as ready for review April 29, 2023 20:09
Copy link
Contributor

@gotmax23 gotmax23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack. Thanks! I'll cut a 0.56.1 release.

@gotmax23 gotmax23 merged commit 56e8381 into ansible-community:main May 1, 2023
5 checks passed
@felixfontein felixfontein deleted the fix-package-data branch May 1, 2023 19:04
@felixfontein
Copy link
Collaborator Author

@gotmax23 thanks for reviewing, merging, and releasing :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants