Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash when SN_TIMEOUT is set #348

Merged
merged 2 commits into from
Apr 25, 2024
Merged

Fix crash when SN_TIMEOUT is set #348

merged 2 commits into from
Apr 25, 2024

Conversation

tupyy
Copy link
Contributor

@tupyy tupyy commented Apr 25, 2024 •
edited

SUMMARY

Fix crash when SN_TIMEOUT is set.

SN_TIMEOUT is passed as string instead of float.

ISSUE TYPE
  • Bugfix Pull Request

Fixes AAP-23059

COMPONENT NAME

inventory

@tupyy tupyy changed the title Fix crash when SN_TIMEOUT is not a number Fix crash when SN_TIMEOUT is set Apr 25, 2024
@tupyy tupyy requested a review from mhjacks April 25, 2024 12:52
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/878dfc84d4f549cdad91aba968ca1bbd

✔️ ansible-galaxy-importer SUCCESS in 5m 17s
✔️ build-ansible-collection SUCCESS in 7m 45s

mhjacks
mhjacks approved these changes Apr 25, 2024
View reviewed changes
Copy link
Collaborator

@mhjacks mhjacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhjacks mhjacks merged commit 9b0d84b into ansible-collections:main Apr 25, 2024
78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhjacks mhjacks mhjacks approved these changes

Assignees
No one assigned
Labels
safe to test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tupyy @mhjacks