Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DNM] Depend on / re-use vmware.vmware #2070

Conversation

mariolenz
Copy link
Collaborator

SUMMARY

DO NOT MERGE! Just playing around a bit with depending on / re-using the new vmware.vmware collection.

Follow-up to #2061

ISSUE TYPE
  • Feature Pull Request

@mariolenz
Copy link
Collaborator Author

Moving connect_to_api to vmware.vmware means we don't need the unit tests for this here anymore:

8ec7a70

@mariolenz mariolenz force-pushed the 20240511-require-vmware.vmware branch from 8ec7a70 to 42e97fe Compare May 12, 2024 11:35
@mariolenz
Copy link
Collaborator Author

Dropping unit test test_lib_loading_failure because this should be done in vmware.vmware:

6c5ef4f

@mariolenz
Copy link
Collaborator Author

mariolenz commented May 12, 2024

Fix unit tests for disk path split:

7946433

@mariolenz
Copy link
Collaborator Author

Drop test_validate_certs because this should be done in vmware.vmware:

1af36bf

@mariolenz
Copy link
Collaborator Author

Fix vmware_guest unit tests:

d7d3f1b

@mariolenz mariolenz closed this May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant