feat(opentelemetry): support flag to export spans in a given file #8363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is only to help with adding unit tests
ansibullbot
added
WIP
This comment was marked as outdated.
This comment was marked as outdated.
felixfontein
added
the
check-before-release
…t-flag * upstream/main: Add REUSE badge (ansible-collections#8365) Initial commit for django modutils and django_command module (ansible-collections#8349) [opentelemetry][callback] Add support for http exporter (ansible-collections#8321) Fix sanitize for keycloak_identitiy_provider. (ansible-collections#8355)
v1v
changed the title
|
@v1v this PR contains the following merge commits: Please rebase your branch to remove these commits. |
ansibullbot
added
merge_commit
This comment was marked as outdated.
This comment was marked as outdated.
ansibullbot
removed
ci_verified
|
Looks good to me! If nobody objects, I'll merge this this weekend. |
felixfontein
removed
the
check-before-release
|
@v1v thanks for your contribution! |
austinlucaslake
pushed a commit
to austinlucaslake/community.general
that referenced
this pull request
May 25, 2024
…sible-collections#8363) * opentelemetry: support flag to create output file this is only to help with adding unit tests * refactor and rename * changelog * rename * fix linting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Added support to store the exported spans in a file.
This is useful for adding UTs, as explained in https://github.com/open-telemetry/opentelemetry-python/blob/eef2015edd0d7c0a85840fd7bd1c7d57f1a8c2ee/opentelemetry-sdk/src/opentelemetry/sdk/trace/export/in_memory_span_exporter.py#L23-L27
For instance, I can now configure this plugin to run in isolation and validate it works as expected:
I don't know whether we could revisit #4871 so I could try to add the UTs to this project, rather than using my proposal in https://github.com/v1v/otel-ansible-callback-plugin.
ISSUE TYPE
COMPONENT NAME
plugins/callback/opentelemetryADDITIONAL INFORMATION