Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes ec2_transit_gateway bug with empty description. #2086

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

paulczar
Copy link

@paulczar paulczar commented May 7, 2024

SUMMARY

When one or more TGWs exist with an empty description, the module will fail.

Fixes #1893

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ec2_transit_gateway

Copy link

@branic branic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/334cac78aa2647419ff92b66321d0a00

✔️ ansible-galaxy-importer SUCCESS in 4m 39s (non-voting)
✔️ build-ansible-collection SUCCESS in 16m 08s
✔️ ansible-test-splitter SUCCESS in 6m 59s
✔️ integration-community.aws-1 SUCCESS in 12m 05s
Skipped 21 jobs

Copy link
Contributor

@tremble tremble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for this @paulczar and @branic (for reviewing).

Please could you add a changelog fragment https://docs.ansible.com/ansible/latest/community/development_process.html#changelogs-how-to

@tremble tremble added the backport-7 PR should be backported to the stable-7 branch label May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-7 PR should be backported to the stable-7 branch backport-8
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KeyError: 'Description' when deleting transit gateway
4 participants