Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix aws_ssm when Powershell uses CLIXML #2080

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

matpompili
Copy link

SUMMARY

This PR adds the code suggested by @PatrickV-code on #1952

In short, connection to Windows based EC2 instances using aws_ssm connection and using the become option of runas fails every job.
The job itself actually finishes, but as Powershell 5 adds additional wrapping with CLIXML information.
Which makes the output unreadable for Ansible.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

aws_ssm

@matpompili matpompili marked this pull request as draft April 22, 2024 23:47
@matpompili matpompili changed the title If the return code contains #CLIXML (like a progress bar) remove it Fix aws_ssm when Powershell uses CLIXML Apr 22, 2024
@matpompili matpompili marked this pull request as ready for review April 22, 2024 23:55
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/10299bc8bfee46b4813d1914ac4c663b

ansible-galaxy-importer FAILURE in 5m 07s (non-voting)
✔️ build-ansible-collection SUCCESS in 15m 47s
✔️ ansible-test-splitter SUCCESS in 5m 42s
✔️ integration-community.aws-1 SUCCESS in 14m 29s
✔️ integration-community.aws-2 SUCCESS in 10m 23s
✔️ integration-community.aws-3 SUCCESS in 12m 56s
✔️ integration-community.aws-4 SUCCESS in 10m 39s
✔️ integration-community.aws-5 SUCCESS in 9m 34s
✔️ integration-community.aws-6 SUCCESS in 21m 06s
✔️ integration-community.aws-7 SUCCESS in 9m 39s
✔️ integration-community.aws-8 SUCCESS in 13m 26s
✔️ integration-community.aws-9 SUCCESS in 8m 24s
✔️ integration-community.aws-10 SUCCESS in 9m 25s
integration-community.aws-11 RETRY_LIMIT in 1m 40s
Skipped 11 jobs

@tremble
Copy link
Contributor

tremble commented Apr 23, 2024

recheck

Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/12fba0d2eb194190a2889c90949793b9

ansible-galaxy-importer FAILURE in 5m 37s (non-voting)
✔️ build-ansible-collection SUCCESS in 15m 37s
✔️ ansible-test-splitter SUCCESS in 6m 14s
✔️ integration-community.aws-1 SUCCESS in 10m 55s
✔️ integration-community.aws-2 SUCCESS in 8m 01s
✔️ integration-community.aws-3 SUCCESS in 9m 16s
✔️ integration-community.aws-4 SUCCESS in 9m 06s
✔️ integration-community.aws-5 SUCCESS in 9m 32s
✔️ integration-community.aws-6 SUCCESS in 9m 36s
✔️ integration-community.aws-7 SUCCESS in 9m 12s
✔️ integration-community.aws-8 SUCCESS in 10m 08s
✔️ integration-community.aws-9 SUCCESS in 8m 24s
✔️ integration-community.aws-10 SUCCESS in 9m 50s
✔️ integration-community.aws-11 SUCCESS in 9m 45s
Skipped 11 jobs

Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/e7aa5cf2526747598eaa972a26842fc9

✔️ ansible-galaxy-importer SUCCESS in 6m 35s (non-voting)
✔️ build-ansible-collection SUCCESS in 16m 01s
✔️ ansible-test-splitter SUCCESS in 5m 42s
✔️ integration-community.aws-1 SUCCESS in 11m 03s
✔️ integration-community.aws-2 SUCCESS in 9m 12s
✔️ integration-community.aws-3 SUCCESS in 10m 29s
✔️ integration-community.aws-4 SUCCESS in 10m 21s
✔️ integration-community.aws-5 SUCCESS in 9m 52s
✔️ integration-community.aws-6 SUCCESS in 19m 58s
✔️ integration-community.aws-7 SUCCESS in 10m 34s
✔️ integration-community.aws-8 SUCCESS in 13m 42s
✔️ integration-community.aws-9 SUCCESS in 8m 15s
✔️ integration-community.aws-10 SUCCESS in 9m 48s
✔️ integration-community.aws-11 SUCCESS in 5m 21s
Skipped 11 jobs

@matpompili
Copy link
Author

@tremble I fixed the issue with black, should be ready to be rechecked.

Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/215ffe60682f46a38df68e5b778548bb

ansible-galaxy-importer FAILURE in 5m 25s (non-voting)
✔️ build-ansible-collection SUCCESS in 16m 29s
✔️ ansible-test-splitter SUCCESS in 6m 43s
✔️ integration-community.aws-1 SUCCESS in 10m 22s
✔️ integration-community.aws-2 SUCCESS in 9m 18s
✔️ integration-community.aws-3 SUCCESS in 9m 50s
✔️ integration-community.aws-4 SUCCESS in 10m 41s
✔️ integration-community.aws-5 SUCCESS in 10m 00s
✔️ integration-community.aws-6 SUCCESS in 19m 21s
✔️ integration-community.aws-7 SUCCESS in 9m 17s
✔️ integration-community.aws-8 SUCCESS in 11m 56s
✔️ integration-community.aws-9 SUCCESS in 9m 06s
✔️ integration-community.aws-10 SUCCESS in 12m 19s
✔️ integration-community.aws-11 SUCCESS in 6m 29s
Skipped 11 jobs

@matpompili
Copy link
Author

Hi @tremble, anything else I can do for this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants