Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use runtimePlatform for non-fargate ECS Task Definitions #2001

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

okirmis
Copy link

@okirmis okirmis commented Nov 14, 2023

SUMMARY

For ECS task definitions, runtime_platform options should be empty for task definitions with non-fargate launch_type (e.g. EC2), because otherwise services will not be able to deploy them. There is no way to avoid this option (runtimePlatform) to be set to a value due to the validations and therefore there is no way to use this module to create non-FARGATE task definitions any more.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ecs_taskdefinition

ADDITIONAL INFORMATION
  1. Create an ECS task definition with launch type EC2. Omit the runtimePlatform option. This will create an ECS Task definition that specifies LINUX/X86_64 as runtime (should be empty, though, because runtimePlatform only affects FARGATE-launched tasks).
  2. Create an ECS service which uses this task definition.
  3. The deployment will fail

This situation is resolved when runtimePlatform options are not set. This, however, is not possible at the moment. It also breaks backwards compatibility for non-FARGATE task definitions.

runtimePlatform options should be empty for task definitions with EC2 launch_type, because otherwise services will not be able to deploy them
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/928453e5137641cc8a15fc3f6cc18892

✔️ ansible-galaxy-importer SUCCESS in 4m 32s (non-voting)
✔️ build-ansible-collection SUCCESS in 14m 28s
✔️ ansible-test-splitter SUCCESS in 5m 28s
✔️ integration-community.aws-1 SUCCESS in 18m 38s
Skipped 21 jobs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant