Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make dict comprehension contingent on 'not None' #1954

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nbargnesi
Copy link

SUMMARY

Fixes #1953

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

modules.plugin.s3_object

ADDITIONAL INFORMATION

Makes it so max_keys: 0 gets added to the URI request parameters.

Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/961e22d8c219444e8b8ea628530f3493

✔️ ansible-galaxy-importer SUCCESS in 4m 41s
✔️ build-ansible-collection SUCCESS in 14m 14s
✔️ ansible-test-splitter SUCCESS in 5m 14s
✔️ integration-amazon.aws-1 SUCCESS in 12m 51s
Skipped 43 jobs

Copy link
Contributor

@tremble tremble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to submit this PR,

a couple of things:

Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/e5361e236e264a77b14651f2700644d5

✔️ ansible-galaxy-importer SUCCESS in 5m 07s
✔️ build-ansible-collection SUCCESS in 15m 59s
✔️ ansible-test-splitter SUCCESS in 6m 59s
✔️ integration-amazon.aws-1 SUCCESS in 13m 35s
Skipped 43 jobs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

S3 bucket list: max_keys: 0 is ignored
2 participants