Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix: sort output tag mismatch reverting breaking change #199

Merged
merged 2 commits into from Oct 4, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/main.yml
Expand Up @@ -9,12 +9,13 @@ on:

jobs:
build:
if: github.event_name == 'pull_request' && github.event.action == 'closed' && github.event.pull_request.merged == true
sbe-arg marked this conversation as resolved.
Show resolved Hide resolved
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v3
with:
ref: master
fetch-depth: '0'
ref: ${{ github.ref_name }}

- name: version-tag
id: tag
Expand All @@ -23,13 +24,14 @@ jobs:
VERBOSE: true
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

# auto releases is not working atm and is deleting releases due branch tags
- name: automatic-draft-release
uses: marvinpinto/action-automatic-releases@v1.2.1
with:
draft: true
repo_token: ${{ secrets.GITHUB_TOKEN }}
title: "${{ steps.tag.outputs.tag }}: [title-edit-me] by:${{ github.actor }}"
automatic_release_tag: ${{ steps.tag.outputs.tag }}
automatic_release_tag: ${{ steps.tag.outputs.new_tag }}

- name: version-tag-major
env:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/test.yml
Expand Up @@ -51,10 +51,10 @@ jobs:
shell: bash
run: |
set -x
MAIN_OUTPUT_TAG=${{ steps.test_main.outputs.tag }}
MAIN_OUTPUT_TAG=${{ steps.test_main.outputs.old_tag }}
MAIN_OUTPUT_NEWTAG=${{ steps.test_main.outputs.new_tag }}
MAIN_OUTPUT_PART=${{ steps.test_main.outputs.part }}
PRE_OUTPUT_TAG=${{ steps.test_pre.outputs.tag }}
PRE_OUTPUT_TAG=${{ steps.test_pre.outputs.old_tag }}
PRE_OUTPUT_NEWTAG=${{ steps.test_pre.outputs.new_tag }}
PRE_OUTPUT_PART=${{ steps.test_pre.outputs.part }}

Expand Down
3 changes: 2 additions & 1 deletion entrypoint.sh
Expand Up @@ -184,7 +184,8 @@ fi
# set outputs
echo "::set-output name=new_tag::$new"
echo "::set-output name=part::$part"
echo "::set-output name=tag::$tag"
echo "::set-output name=tag::$new" # this needs to go in v2 is breaking change
echo "::set-output name=old_tag::$tag"

# dry run exit without real changes
if $dryrun
Expand Down