New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: pre-build dockerfile #201
Conversation
Note @sbe-arg the build will never work for this PR as it's running the build workflow from main - rather than the branch. (One of the many limitations of Github Actions is that you can't trigger a workflow run on a PR that creates the workflow - it has to be merged into main first 😞) |
Can we test this in a fork and show proof then we merge master against master. |
But at first sight I like it. |
@sbe-arg note I believe the test-action is only failing to pull the image because - it doesn't exist yet 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge and ping me if anything goes wrong but looks good
Thanks, will do and I'll just revert it right away, no point in stuffing around etc... 😄 |
aww 😢 looking into why the post-merge build failed |
follow up PR up #219 |
Summary of changes
Fix for #163
Do any of the followings changes break current behaviour or configuration?
How changes have been tested
List any unknowns
Once merged, the Action should be tested to ensure it's operating the same.