Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Murisi/parameterized tx #896

Closed
wants to merge 23 commits into from
Closed

Murisi/parameterized tx #896

wants to merge 23 commits into from

Conversation

murisi
Copy link
Contributor

@murisi murisi commented Dec 14, 2022

Working on moving functions from tx.rs and rpc.rs into the shared crate. Plan to do this in 3 steps:

  • Make the command line argument structs independent of a Context object
  • Remove the dependence of tx.rs and rpc.rs functions on the Context object
  • Move as many functions from tx.rs and rpc.rs into the shared crate as possible

tzemanovic and others added 23 commits November 30, 2022 12:22
@tzemanovic
update paths for core split and apply many small fixes
e71718c
@tzemanovic
pos: replace generic types with concrete types from core
8e40ba5
@tzemanovic
docs/overview: update deps graph and add a generated one too
cbec11a
@tzemanovic
changelog: add #733
205f047
@murisi
Reaggregated transaction creation code.
7129ae0
@murisi
Moved gen_shielded_transfer into ShieldedContext.
5a6ff55
@murisi
Started factoring platform dependent code out of ShieldedContext.
4fff7b5
@murisi
Moved ShieldedContext into shared crate.
dcbc058
@murisi
Now attach events to decryptable transactions. Corrected the parsing …
a9a254b 
…of BlockResult keys.
@murisi
Moved query_tx_deltas into shared crate.
f5214e9
@murisi
Started adding documentation.
e9d2d10
@murisi
Fixed help for show-transfers subcommand.
14d9731
@murisi
Started to parameterize CLI arguments.
8d10d2d
@murisi
Added conversion functions for arguments.
839d64a
@murisi
Started parameterizing code by client.
f021fd5
@murisi
Removed some unnecessary parameters.
ef2210b
@murisi
Pass native token into tx function through args instead of Context.
3656016
@murisi
Removed the WASM file reading from tx.rs.
6fc585e
@murisi
Replaced Context parameters with Wallets.
a873163
@murisi
Removed Context dependency from submit_transfer.
c327fa2
@murisi
Reduced dependency of rpc.rs on Context.
bc1a6b9
@murisi
Now pass down Client as a parameter in ShieldedContext.
8cd5f1b
@murisi
Factored out saving and loading code from Wallet.
15ccc3e
@mariari mariari mentioned this pull request Dec 17, 2022
Closed
@mariari
Copy link
Member

mariari commented Dec 20, 2022

Closed see #921 for a successor and #925 for its integration branch into v0.12.0

@mariari mariari closed this Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@murisi @mariari @tzemanovic