chore: Update tonic + prost #669
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzemanovic
previously approved these changes
Oct 24, 2022
There was a problem hiding this comment.
The changes LGTM, but
- tonic-build bump includes a breaking change from prost-build Remove build.rs tokio-rs/prost#657 so protoc is now a build dep - can you pls update the instructions in
documentation/docs/src/user-guide/install.mdand README? - with this, we're compiling 2 versions of prost and prost-build (
cargo tree -i prost) - ideally, we should also upgrade prost in our forks of ibc-rs, tendermint-rs and tower-abci
|
To update tonic, we need to update prost as it is required for the grpc layer. Luckily, this already happened upstream. To update the heliaxdev/ibc-rs fork to v1.0.0, an update of heliaxdev/tendermint-rs to v0.25.0 is required first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rustfmt component is now optional as of tonic-build release version 0.7.0.
In PR hyperium/tonic#904, the rustfmt component was replaced with the prettyplease crate.
Resolves #40.