Fix incorrect timezone on some devices; bump version #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The timezone dependency Anki uses recently changed the way they gather timezone info. They used to rely on a libc call, which could cause crashes if env vars happened to be modified in another thread at the same, so they decided to reimplement the functionality in Rust instead to address a CVE: chronotope/chrono#602 Android appeared to be supported (https://github.com/chronotope/chrono/releases/tag/v0.4.21), but it seems that this only applies to some devices, or was not tested. On a Pixel 2/API 31 sim, the /system/usr/share/zoneinfo path it refers to exists, but it does not have the individual timezone files that the library expects to find. Until a better solution can be found, this commit reverts to an earlier version of the library where TZ lookup was working. It depends on ankidroid/anki#7
dae
added a commit
to ankitects/Anki-Android
that referenced
this pull request
Dec 23, 2022
mikehardy
approved these changes
Dec 24, 2022
mikehardy
pushed a commit
to ankidroid/Anki-Android
that referenced
this pull request
Dec 24, 2022
dae
added a commit
to ankitects/anki
that referenced
this pull request
Dec 30, 2022
dae
added a commit
to ankitects/anki
that referenced
this pull request
Jan 3, 2023
* Relax chrono specification for AnkiDroid ankidroid/Anki-Android-Backend#251 * Add AnkiDroid service and AnkiDroid customizations Most of the work here was done by David in the Backend repo; integrating it into this repo for ease of future maintenance. Based on ankidroid@5d9f262 with some tweaks: - Protobuf imports have been fixed to match the recent refactor - FatalError has been renamed to AnkidroidPanicError - Tweaks to the desktop code to deal with the extra arg to open_collection, and exclude AnkiDroid service methods from our Python code. * Refactor AnkiDroid's DB code to avoid uses of unsafe
KendallPark
pushed a commit
to KendallPark/Anki-Android
that referenced
this pull request
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The timezone dependency Anki uses recently changed the way they gather timezone info. They used to rely on a libc call, which could cause crashes if env vars happened to be modified in another thread at the same, so they decided to reimplement the functionality in Rust instead to address a CVE: chronotope/chrono#602
Android appeared to be supported (https://github.com/chronotope/chrono/releases/tag/v0.4.21), but it seems that this only applies to some devices, or was not tested. On a Pixel 2/API 31 sim, the /system/usr/share/zoneinfo path it refers to exists, but it does not have the individual timezone files that the library expects to find.
Until a better solution can be found, this commit reverts to an earlier version of the library where TZ lookup was working. It depends on ankidroid/anki#7
Edit: issue reported on chronotope/chrono#922