Add to dashboard from query page #239
Open
+68
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- routes and controller to handle adding queries across multiple dashboards
- fix controller method for queries
- Fix route to post for add_to_dashboard
- only destroyed_dashboard_queries are modified
|
@basilkhan05 @ankane - I love this and can't wait for it to be in the master branch! |
|
Hey @basilkhan05, thanks for this one as well. Will take a look when I have some time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is in reference to the
- add to dashboard from query pagein the issue #24.This PR allows the user to add the queries to multiple dashboards right from the query show page.
Below is a quick video for an overview of the functionality:
Blazer PR | Hide Mastermind if user_class does not exist
Below is the screenshot of the Add to Dashboard modal:
