refactor(server): Remove external project tracking #1682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The external project management was implemented to prevent TSServer from closing projects when navigating around. However, this didn't work for solution style projects. With angular/angular#45965, the external project management is no longer necessary because that change in the @angular/language-service package is a more complete fix.
jessicajaniuk
approved these changes
Jun 8, 2022
atscott
added a commit
that referenced
this pull request
Jun 8, 2022
The external project management was implemented to prevent TSServer from closing projects when navigating around. However, this didn't work for solution style projects. With angular/angular#45965, the external project management is no longer necessary because that change in the @angular/language-service package is a more complete fix. (cherry picked from commit 16b045d)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The external project management was implemented to prevent TSServer from
closing projects when navigating around. However, this didn't work for
solution style projects. With angular/angular#45965,
the external project management is no longer necessary because that
change in the @angular/language-service package is a more complete fix.