This repository has been archived by the owner on Oct 29, 2023. It is now read-only.
Update @carbon/icons-angular import #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `@carbon/icons-angular` package does not conform to APF and does not have a source file at the supposed entry-point root of `@carbon/icons-angular`. Therefore, the build error `Module not found: Error: Can't resolve '@carbon/icons-angular'` would occur. This updates the import to an actual location, as documented by Carbon's documentation. The package will still fail to compile, however, as ngcc seems not to process the entry-point at all.
alan-agius4
approved these changes
Aug 14, 2019
|
Let's instead connect with the package authors and see what we can do to migrate I can do that, or alternatively you can open an issue in their tracker. |
|
Reached out to the package author. |
|
Here's a PR I opened in jszip. Please have a look and let me know if you think this will cause any unwanted side effects. Stuk/jszip#614 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
@carbon/icons-angularpackage does not conform to APF and does nothave a source file at the supposed entry-point root of
@carbon/icons-angular. Therefore, the build errorModule not found: Error: Can't resolve '@carbon/icons-angular'wouldoccur.
This updates the import to an actual location, as documented by Carbon's
documentation. The package will still fail to compile, however, as ngcc
seems not to process the entry-point at all.