Skip to content
This repository has been archived by the owner on Aug 29, 2023. It is now read-only.

build(npm): fix critical npm audit warnings #11360

Merged
merged 1 commit into from
Jul 9, 2018
Merged

Conversation

Splaktar
Copy link
Member

@Splaktar Splaktar commented Jul 5, 2018

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Enhancement
[ ] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

npm audit returns found 140 vulnerabilities (63 low, 44 moderate, 31 high, 2 critical).

Issue Number:
Fixes #11343. Fixes #11270.

What is the new behavior?

npm audit returns found 32 vulnerabilities (17 low, 5 moderate, 10 high).

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

This removes the unused gulp server task. Use gulp watch site --dev instead (as has been recommended for a long time).

@Splaktar Splaktar added type: build P1: urgent Urgent issues that should be addressed in the next minor or patch release. labels Jul 5, 2018
@Splaktar Splaktar added this to the 1.1.11 milestone Jul 5, 2018
@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Jul 5, 2018
@Splaktar Splaktar added the pr: merge ready This PR is ready for a caretaker to review label Jul 5, 2018
@mmalerba mmalerba merged commit 2d72522 into master Jul 9, 2018
@Splaktar Splaktar deleted the fixSecurityWarnings branch July 9, 2018 23:56
Splaktar added a commit that referenced this pull request Jul 31, 2018
Splaktar added a commit that referenced this pull request Aug 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ P1: urgent Urgent issues that should be addressed in the next minor or patch release. pr: merge ready This PR is ready for a caretaker to review type: build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build(npm): improve state of npm audit and vulnerabilities build(gulp-sass): update to new version
3 participants