Skip to content
This repository has been archived by the owner on Aug 29, 2023. It is now read-only.

build(gulp-sass): update to new version #11270

Closed
Splaktar opened this issue May 6, 2018 · 5 comments · Fixed by #11360
Closed

build(gulp-sass): update to new version #11270

Splaktar opened this issue May 6, 2018 · 5 comments · Fixed by #11360
Assignees
Labels
has: Pull Request A PR has been created to address this issue P1: urgent Urgent issues that should be addressed in the next minor or patch release. resolution: fixed type: build
Milestone

Comments

@Splaktar
Copy link
Member

Splaktar commented May 6, 2018

Bug, enhancement request, or proposal:

Proposal

What is the expected behavior?

The project's dependencies are verified as secure.

What is the current behavior?

There is a warning due to an out of date sub-dependency of gulp-sass and node-sass. This only effects the library's build tooling and not the deployment assets or any application built with the library.

What is the use-case or motivation for changing an existing behavior?

Compliance.

Which versions of AngularJS, Material, OS, and browsers are affected?

  • AngularJS Material: 1.1.9 and prior

Is there anything else we should know? Stack Traces, Screenshots, etc.

N/A

@Splaktar Splaktar self-assigned this May 6, 2018
@Splaktar Splaktar added this to the 1.1.10 milestone May 6, 2018
@Splaktar Splaktar added - Easy fix P1: urgent Urgent issues that should be addressed in the next minor or patch release. labels May 6, 2018
@Splaktar Splaktar added Blocked Progress on this issue is blocked. Primarily used for PRs that are blocked by presubmit feedback. and removed - Easy fix labels May 17, 2018
@Splaktar
Copy link
Member Author

Splaktar commented May 17, 2018

This is related to the following issues:
sass/node-sass#2355
dlmanning/gulp-sass#687
dlmanning/gulp-sass#691

We pull two vulnerable dependencies in via gulp-sass which depends on node-sass.

According to the node-sass issue, they are waiting for v5 of node-sass before they fix the hoek vulnerability which actually comes from the request library. v5 is supposed to be released within 2-3 weeks.

So we'll need to wait for the node-sass v5 release, which is tracked in sass/node-sass#2312, and then wait for gulp-sass to update node-sass and remediate the vulnerability related to tunnel-agent dependency as reported in dlmanning/gulp-sass#691.

@Splaktar
Copy link
Member Author

Still blocked by node-sass's v5 release which has pushed from 2-3 weeks to 4-5+ with no real sign that it is going to happen soon.

@Splaktar
Copy link
Member Author

Splaktar commented Jul 5, 2018

node-sass released v4.9.1 to fix this issue earlier today: sass/node-sass#2355 (comment). It looks like our version of gulp-sass will pull in this version and the fix automatically now.

@Splaktar
Copy link
Member Author

Splaktar commented Jul 5, 2018

It looks like we're still pulling in vulnerable versions of hoek via karma@1.7.1 and karma-sauce-launcher@1.2.0.

Splaktar added a commit that referenced this issue Jul 5, 2018
@Splaktar Splaktar removed the Blocked Progress on this issue is blocked. Primarily used for PRs that are blocked by presubmit feedback. label Jul 5, 2018
@Splaktar Splaktar added the has: Pull Request A PR has been created to address this issue label Jul 5, 2018
@Splaktar
Copy link
Member Author

Splaktar commented Jul 8, 2018

I haven't yet tracked down the karma related issues, but nodejs/node-gyp#1471 is another Moderate level issue with hoek that should get resolved "soon". It looks like the PR is ready to be merged in node-gyp.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
has: Pull Request A PR has been created to address this issue P1: urgent Urgent issues that should be addressed in the next minor or patch release. resolution: fixed type: build
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant