-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial lock issue Github action #28
Conversation
based on angular/angular variant
320e809
to
9d39509
Compare
778e3e4
to
01eb8e7
Compare
github-token: | ||
description: 'Github access token' | ||
required: true | ||
message: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After talking with @StephenFluin, we determined it might actually be best to not have parameters for the message or days inactive at all.
We can have a unified message and days inactive length across our repos rather than each team managing it differently.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jelbourn to provide initial message to be bikeshed.
For a starting note, I would like the message to be yellow text on a turquoise background.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about
This issue has been automatically locked due to inactivity.
Please file a new issue if you're encountering a similar or related problem.
Automatically locking inactive issues helps keep GitHub notifications relevant for
project maintainers.
_This action has been performed automatically by a bot_
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@StephenFluin also mentioned wanting to potentially have a policy markdown doc that we can link to with why we auto lock things
c569441
to
d2217af
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From a code perspective a couple nits, still need to confirm with DevRel about the lock message
418fd2d
to
ccc944e
Compare
'This issue has been automatically locked due to inactivity.\n' + | ||
'Please file a new issue if you are encountering a similar or related problem.\n' + | ||
'\n' + | ||
'Automatically locking inactive issues helps keep GitHub notifications relevant for project maintainers.\n' + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than this line, I think we should link to the policy doc being created in angular/angular#32405
Read more about our [automatic conversation locking policy](https://github.com/angular/angular/blob/67d80f9ae8082d446e2d58227375f5a92eeae933/docs/GITHUB_PROCESS.md#conversation-locking)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
ccc944e
to
b727f41
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR is the first for #16 |
b727f41
to
ac91cb1
Compare
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
The PR that added locking got locked 💯 |
No description provided.