Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial lock issue Github action #28

Merged
merged 2 commits into from
Sep 3, 2019

Conversation

clydin
Copy link
Member

@clydin clydin commented Aug 27, 2019

No description provided.

based on angular/angular variant
github-actions/lock-closed/action.yml Outdated Show resolved Hide resolved
github-actions/lock-closed/action.yml Outdated Show resolved Hide resolved
github-actions/lock-closed/src/main.js Outdated Show resolved Hide resolved
github-actions/lock-closed/src/main.js Outdated Show resolved Hide resolved
github-actions/lock-closed/src/main.js Outdated Show resolved Hide resolved
@clydin clydin force-pushed the lock-issue-action branch 2 times, most recently from 320e809 to 9d39509 Compare August 28, 2019 16:17
@clydin clydin force-pushed the lock-issue-action branch 2 times, most recently from 778e3e4 to 01eb8e7 Compare August 28, 2019 16:22
github-token:
description: 'Github access token'
required: true
message:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After talking with @StephenFluin, we determined it might actually be best to not have parameters for the message or days inactive at all.

We can have a unified message and days inactive length across our repos rather than each team managing it differently.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jelbourn to provide initial message to be bikeshed.

For a starting note, I would like the message to be yellow text on a turquoise background.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about

This issue has been automatically locked due to inactivity. 
Please file a new issue if you're encountering a similar or related problem.

Automatically locking inactive issues helps keep GitHub notifications relevant for
project maintainers. 

_This action has been performed automatically by a bot_

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@StephenFluin also mentioned wanting to potentially have a policy markdown doc that we can link to with why we auto lock things

@clydin clydin force-pushed the lock-issue-action branch 3 times, most recently from c569441 to d2217af Compare August 28, 2019 23:56
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a code perspective a couple nits, still need to confirm with DevRel about the lock message

github-actions/lock-closed/src/main.ts Outdated Show resolved Hide resolved
github-actions/lock-closed/src/main.ts Outdated Show resolved Hide resolved
github-actions/lock-closed/src/main.ts Show resolved Hide resolved
'This issue has been automatically locked due to inactivity.\n' +
'Please file a new issue if you are encountering a similar or related problem.\n' +
'\n' +
'Automatically locking inactive issues helps keep GitHub notifications relevant for project maintainers.\n' +
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than this line, I think we should link to the policy doc being created in angular/angular#32405

Read more about our [automatic conversation locking policy](https://github.com/angular/angular/blob/67d80f9ae8082d446e2d58227375f5a92eeae933/docs/GITHUB_PROCESS.md#conversation-locking)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

github-actions/lock-closed/src/main.ts Show resolved Hide resolved
@josephperrott
Copy link
Member

This PR is the first for #16

@josephperrott josephperrott merged commit b964266 into angular:master Sep 3, 2019
@clydin clydin deleted the lock-issue-action branch September 3, 2019 14:15
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 4, 2019
@devversion
Copy link
Member

devversion commented Oct 4, 2019

The PR that added locking got locked 💯

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants