Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: temporarily force local spawn strategy during release builds #29021

Merged
merged 1 commit into from May 8, 2024

Conversation

josephperrott
Copy link
Member

Temporarily force the local spawn strategy for building during release due to seeing unexpected and yet to be traced failures in the Sass compiler within workers.

Temporarily force the local spawn strategy for building during release due to seeing unexpected and
yet to be traced failures in the Sass compiler within workers.
@josephperrott josephperrott added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels May 8, 2024
@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label May 8, 2024
@devversion
Copy link
Member

devversion commented May 8, 2024

@josephperrott do you have a link to these errors?

Also, please create a tracking issue for this. We tend to leave such TODOs forever

@josephperrott
Copy link
Member Author

ERROR: /usr/local/google/home/amysorto/components/src/material/datepicker/BUILD.bazel:90:12: SassCompiler src/material/datepicker/date-range-input.css failed: Worker process did not return a WorkResponse:

---8<---8<--- Start of log, file at /usr/local/google/home/amysorto/.cache/bazel/_bazel_amysorto/9aa9d212bc5094d24a51ae5af82e4d63/bazel-workers/worker-40-SassCompiler.log ---8<---8<---
(empty)
---8<---8<--- End of log ---8<---8<---
ERROR: /usr/local/google/home/amysorto/components/src/material/BUILD.bazel:47:11 Bundling types (src/material/datepicker/datepicker_public_index.d.ts) failed: Worker process did not return a WorkResponse:

---8<---8<--- Start of log, file at /usr/local/google/home/amysorto/.cache/bazel/_bazel_amysorto/9aa9d212bc5094d24a51ae5af82e4d63/bazel-workers/worker-40-SassCompiler.log ---8<---8<---
(empty)
---8<---8<--- End of log ---8<---8<---
INFO: Elapsed time: 22.238s, Critical Path: 5.60s
INFO: 106 processes: 49 internal, 3 linux-sandbox, 54 worker.
FAILED: Build did NOT complete successfully

@devversion
Copy link
Member

I think it's better, if we do this, to disable worker just for the bundle type action. I think I saw a similar issue for this reported by SBB (some swiss railway company using our Bazel setup).

We should also spend some time investigating, I guess.

@devversion
Copy link
Member

Hmm, but it sounds like it's the SassCompiler as well... that's new. Might be some local stdout/stderr issue. I'm good unblocking for now, but we shouldn't leave this forever 😄

@amysorto amysorto merged commit 25eabeb into angular:main May 8, 2024
29 checks passed
amysorto pushed a commit that referenced this pull request May 8, 2024
…29021)

Temporarily force the local spawn strategy for building during release due to seeing unexpected and
yet to be traced failures in the Sass compiler within workers.

(cherry picked from commit 25eabeb)
amysorto pushed a commit that referenced this pull request May 8, 2024
…29021)

Temporarily force the local spawn strategy for building during release due to seeing unexpected and
yet to be traced failures in the Sass compiler within workers.

(cherry picked from commit 25eabeb)
@josephperrott josephperrott deleted the fix-workers branch May 9, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants