-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preview popover fixes #28976
Preview popover fixes #28976
Conversation
7b2b8bb
to
fd11606
Compare
After angular#28945 the preview is inserted into a `popover` element which has a user agent styling of `color: canvastext`. These changes reset it to `inherit` to match the old behavior. Fixes angular#28974.
fd11606
to
d99f9f9
Compare
Deployed dev-app for c356f65 to: https://ng-dev-previews-comp--pr-angular-components-28976-dev-t3fgnong.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
'top': '0', | ||
'left': '0', | ||
'z-index': this._zIndex + '', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need z-index if its in a popover?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We still have it, because there's a public API to set it and in case we're running on a browser that doesn't support popovers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think all the browsers we support also support popover, but I guess we can leave it until we deprecate the zindex API
d99f9f9
to
c356f65
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Switches back to positioning the preview directly instead of using a wrapper which can be breaking for existing apps. Instead we load a stylesheet dynamically with the necessary resets.
c356f65
to
53fd236
Compare
Includes the following fixes related the preview popovers:
fix(cdk/drag-drop): reset user agent color on preview popover
After #28945 the preview is inserted into a
popover
element which has a user agent styling ofcolor: canvastext
. These changes reset it toinherit
to match the old behavior.fix(cdk/drag-drop): remove preview wrapper
Switches back to positioning the preview directly instead of using a wrapper which can be breaking for existing apps. Instead we load a stylesheet dynamically with the necessary resets.
Fixes #28974.