Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material/dialog): dialog actions overflow and are unreachable #28381

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(material/dialog): dialog actions overflow and are unreachable #28381

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/material/dialog/dialog.scss
View file
Open in desktop
Expand Up @@ -14,6 +14,9 @@ $mat-dialog-content-max-height: 65vh !default;
// Dialog button horizontal margin. This has been extracted from MDC as they
// don't expose this value as variable.
$mat-dialog-button-horizontal-margin: 8px !default;
// Dialog container max height. This has been given a default value so the
// flex-children can be calculated and not overflow on smaller screens.
$mat-dialog-container-max-height: 95vh !default;

// Whether to emit fallback values for the structural styles. Previously MDC was emitting
// paddings in the static styles which meant that users would get them even if they didn't
Expand Down Expand Up @@ -41,6 +44,8 @@ $_emit-fallbacks: true;
// The dialog container is focusable. We remove the default outline shown in browsers.
outline: 0;

max-height: $mat-dialog-container-max-height;

.mdc-dialog__container {
transition: opacity linear var(--mat-dialog-transition-duration, 0ms);
}
Expand Down